From mboxrd@z Thu Jan 1 00:00:00 1970 From: "tiejun.chen" Subject: Re: [RFC][KVM][PATCH 1/1] kvm:ppc:booke-64: soft-disable interrupts Date: Mon, 6 May 2013 11:13:17 +0800 Message-ID: <51871FCD.9070900@windriver.com> References: <1367809831-28838-1-git-send-email-tiejun.chen@windriver.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Cc: , , To: , Benjamin Herrenschmidt Return-path: In-Reply-To: <1367809831-28838-1-git-send-email-tiejun.chen@windriver.com> Sender: kvm-ppc-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 05/06/2013 11:10 AM, Tiejun Chen wrote: > For the external interrupt, the decrementer exception and the doorbell > excpetion, we also need to soft-disable interrupts while doing as host > interrupt handlers since the DO_KVM hook is always performed to skip > EXCEPTION_COMMON then miss this original chance with the 'ints' (INTS_DISABLE). Sorry, miss to send Ben. Tiejun > > Signed-off-by: Tiejun Chen > --- > arch/powerpc/kvm/bookehv_interrupts.S | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/arch/powerpc/kvm/bookehv_interrupts.S b/arch/powerpc/kvm/bookehv_interrupts.S > index e8ed7d6..2fd62bf 100644 > --- a/arch/powerpc/kvm/bookehv_interrupts.S > +++ b/arch/powerpc/kvm/bookehv_interrupts.S > @@ -33,6 +33,8 @@ > > #ifdef CONFIG_64BIT > #include > +#include > +#include > #else > #include "../kernel/head_booke.h" /* for THREAD_NORMSAVE() */ > #endif > @@ -469,6 +471,13 @@ _GLOBAL(kvmppc_resume_host) > PPC_LL r3, HOST_RUN(r1) > mr r5, r14 /* intno */ > mr r14, r4 /* Save vcpu pointer. */ > +#ifdef CONFIG_64BIT > + /* Should we soft-disable interrupts? */ > + andi. r6, r5, BOOKE_INTERRUPT_EXTERNAL | BOOKE_INTERRUPT_DECREMENTER | BOOKE_INTERRUPT_DOORBELL > + beq skip_soft_dis > + SOFT_DISABLE_INTS(r7,r8) > +skip_soft_dis: > +#endif > bl kvmppc_handle_exit > > /* Restore vcpu pointer and the nonvolatiles we used. */ >