* [PATCH] vhost-scsi: Enable VIRTIO_RING_F_EVENT_IDX
@ 2013-05-07 6:51 Asias He
2013-05-07 8:03 ` Paolo Bonzini
0 siblings, 1 reply; 2+ messages in thread
From: Asias He @ 2013-05-07 6:51 UTC (permalink / raw)
To: Michael S. Tsirkin; +Cc: kvm, virtualization, target-devel
It is disabled as a workaround. Now userspace bits works fine with it.
So, let's enable it.
Signed-off-by: Asias He <asias@redhat.com>
---
drivers/vhost/scsi.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c
index d860b58..5531ebc 100644
--- a/drivers/vhost/scsi.c
+++ b/drivers/vhost/scsi.c
@@ -160,14 +160,8 @@ enum {
VHOST_SCSI_VQ_IO = 2,
};
-/*
- * VIRTIO_RING_F_EVENT_IDX seems broken. Not sure the bug is in
- * kernel but disabling it helps.
- * TODO: debug and remove the workaround.
- */
enum {
- VHOST_SCSI_FEATURES = (VHOST_FEATURES & (~VIRTIO_RING_F_EVENT_IDX)) |
- (1ULL << VIRTIO_SCSI_F_HOTPLUG)
+ VHOST_SCSI_FEATURES = VHOST_FEATURES | (1ULL << VIRTIO_SCSI_F_HOTPLUG)
};
#define VHOST_SCSI_MAX_TARGET 256
--
1.8.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] vhost-scsi: Enable VIRTIO_RING_F_EVENT_IDX
2013-05-07 6:51 [PATCH] vhost-scsi: Enable VIRTIO_RING_F_EVENT_IDX Asias He
@ 2013-05-07 8:03 ` Paolo Bonzini
0 siblings, 0 replies; 2+ messages in thread
From: Paolo Bonzini @ 2013-05-07 8:03 UTC (permalink / raw)
To: Asias He; +Cc: virtualization, target-devel, kvm, Michael S. Tsirkin
Il 07/05/2013 08:51, Asias He ha scritto:
> It is disabled as a workaround. Now userspace bits works fine with it.
> So, let's enable it.
>
> Signed-off-by: Asias He <asias@redhat.com>
> ---
> drivers/vhost/scsi.c | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c
> index d860b58..5531ebc 100644
> --- a/drivers/vhost/scsi.c
> +++ b/drivers/vhost/scsi.c
> @@ -160,14 +160,8 @@ enum {
> VHOST_SCSI_VQ_IO = 2,
> };
>
> -/*
> - * VIRTIO_RING_F_EVENT_IDX seems broken. Not sure the bug is in
> - * kernel but disabling it helps.
> - * TODO: debug and remove the workaround.
> - */
> enum {
> - VHOST_SCSI_FEATURES = (VHOST_FEATURES & (~VIRTIO_RING_F_EVENT_IDX)) |
> - (1ULL << VIRTIO_SCSI_F_HOTPLUG)
> + VHOST_SCSI_FEATURES = VHOST_FEATURES | (1ULL << VIRTIO_SCSI_F_HOTPLUG)
> };
>
> #define VHOST_SCSI_MAX_TARGET 256
>
The broken version was not ever committed to QEMU, I guess the same is
true for nlkt.
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Paolo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-07 8:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-07 6:51 [PATCH] vhost-scsi: Enable VIRTIO_RING_F_EVENT_IDX Asias He
2013-05-07 8:03 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox