From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marc Zyngier Subject: Re: [PATCH v3 07/32] arm64: KVM: fault injection into a guest Date: Tue, 07 May 2013 17:29:37 +0100 Message-ID: <51892BF1.9070501@arm.com> References: <1365437854-30214-1-git-send-email-marc.zyngier@arm.com> <1365437854-30214-8-git-send-email-marc.zyngier@arm.com> <20130429162652.GA16544@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: 8BIT Cc: "linux-arm-kernel@lists.infradead.org" , "kvmarm@lists.cs.columbia.edu" , "kvm@vger.kernel.org" , Will Deacon , Christopher Covington To: Catalin Marinas Return-path: Received: from service87.mimecast.com ([91.220.42.44]:51253 "EHLO service87.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753107Ab3EGQ3l convert rfc822-to-8bit (ORCPT ); Tue, 7 May 2013 12:29:41 -0400 In-Reply-To: <20130429162652.GA16544@arm.com> Sender: kvm-owner@vger.kernel.org List-ID: On 29/04/13 17:26, Catalin Marinas wrote: > On Mon, Apr 08, 2013 at 05:17:09PM +0100, Marc Zyngier wrote: >> +static void inject_abt64(struct kvm_vcpu *vcpu, bool is_iabt, unsigned long addr) >> +{ >> + unsigned long cpsr = *vcpu_cpsr(vcpu); >> + int is_aarch32; >> + u32 esr = 0; >> + >> + is_aarch32 = vcpu_mode_is_32bit(vcpu); > > Minor thing - use bool here to match the function definition? Sure, will do. M. -- Jazz is not dead. It just smells funny...