From: David Daney <ddaney@caviumnetworks.com>
To: Gleb Natapov <gleb@redhat.com>
Cc: David Daney <ddaney.cavm@gmail.com>, <linux-mips@linux-mips.org>,
<ralf@linux-mips.org>, <kvm@vger.kernel.org>,
Sanjay Lal <sanjayl@kymasys.com>, <linux-kernel@vger.kernel.org>,
David Daney <david.daney@cavium.com>
Subject: Re: [PATCH v3 5/5] mips/kvm: Fix ABI by moving manipulation of CP0 registers to KVM_{G,S}ET_MSRS
Date: Tue, 21 May 2013 09:21:06 -0700 [thread overview]
Message-ID: <519B9EF2.8020107@caviumnetworks.com> (raw)
In-Reply-To: <20130521153752.GD14287@redhat.com>
On 05/21/2013 08:37 AM, Gleb Natapov wrote:
> On Mon, May 20, 2013 at 02:01:26PM -0700, David Daney wrote:
>> From: David Daney <david.daney@cavium.com>
>>
>> Because not all 256 CP0 registers are ever implemented, we need a
>> different method of manipulating them. Use the
>> KVM_GET_MSRS/KVM_SET_MSRS mechanism as x86 does for its MSRs.
>>
> Have you looked at KVM_(GET|SET)_ONE_REG interface (not used by x86, but is
> used bu arm/ppc/s390). It looks like it is more suitable for your case.
> Actually you can use it instead of KVM_(GET|SET)_REGS for all registers.
Yes, I suppose it could be used. One problem it has is that there is no
way to query the set of supported registers. Also you have to make
multiple calls to set multiple registers, which involves vcpu_{load,put}
for each register.
We will definitely implement it for all the FP and General Purpose
registers.
>
>> Code related to implementing KVM_GET_MSRS/KVM_SET_MSRS is consolidated
next prev parent reply other threads:[~2013-05-21 16:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-20 21:01 [PATCH v3 0/5] mips/kvm: Fix ABI for compatibility with 64-bit guests David Daney
2013-05-20 21:01 ` [PATCH v3 1/5] mips/kvm: Fix ABI for use of FPU David Daney
2013-05-20 21:01 ` [PATCH v3 2/5] mips/kvm: Fix ABI for use of 64-bit registers David Daney
2013-05-20 21:01 ` [PATCH v3 3/5] mips/kvm: Fix name of gpr field in struct kvm_regs David Daney
2013-05-20 21:01 ` [PATCH v3 4/5] mips/kvm: Use ARRAY_SIZE() instead of hardcoded constants in kvm_arch_vcpu_ioctl_{s,g}et_regs David Daney
2013-05-20 21:01 ` [PATCH v3 5/5] mips/kvm: Fix ABI by moving manipulation of CP0 registers to KVM_{G,S}ET_MSRS David Daney
2013-05-21 15:37 ` Gleb Natapov
2013-05-21 16:21 ` David Daney [this message]
2013-05-21 16:28 ` Gleb Natapov
2013-05-21 16:34 ` David Daney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=519B9EF2.8020107@caviumnetworks.com \
--to=ddaney@caviumnetworks.com \
--cc=david.daney@cavium.com \
--cc=ddaney.cavm@gmail.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=sanjayl@kymasys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox