From: Paolo Bonzini <pbonzini@redhat.com>
To: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: Marcelo Tossati <mtosatti@redhat.com>,
Gleb Natapov <gleb@redhat.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
KVM <kvm@vger.kernel.org>,
linux-s390 <linux-s390@vger.kernel.org>
Subject: Re: [PATCH] KVM: s390: Add "devname:kvm" alias.
Date: Tue, 28 May 2013 11:00:33 +0200 [thread overview]
Message-ID: <51A47231.8020001@redhat.com> (raw)
In-Reply-To: <1369672953-33705-2-git-send-email-cornelia.huck@de.ibm.com>
Il 27/05/2013 18:42, Cornelia Huck ha scritto:
> Providing a "devname:kvm" module alias enables automatic loading of
> the kvm module when /dev/kvm is opened.
>
> Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
> ---
> arch/s390/kvm/kvm-s390.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
> index 93444c4..3b597e5 100644
> --- a/arch/s390/kvm/kvm-s390.c
> +++ b/arch/s390/kvm/kvm-s390.c
> @@ -1138,3 +1138,12 @@ static void __exit kvm_s390_exit(void)
>
> module_init(kvm_s390_init);
> module_exit(kvm_s390_exit);
> +
> +/*
> + * Enable autoloading of the kvm module.
> + * Note that we add the module alias here instead of virt/kvm/kvm_main.c
> + * since x86 takes a different approach.
> + */
> +#include <linux/miscdevice.h>
> +MODULE_ALIAS_MISCDEV(KVM_MINOR);
> +MODULE_ALIAS("devname:kvm");
>
Looks good for 3.10. Should I take this since Alex is on holiday, or
should I wait for him to come back?
Paolo
next prev parent reply other threads:[~2013-05-28 9:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-27 16:42 [PATCH] KVM: s390: Module autoloading Cornelia Huck
2013-05-27 16:42 ` [PATCH] KVM: s390: Add "devname:kvm" alias Cornelia Huck
2013-05-28 9:00 ` Paolo Bonzini [this message]
2013-05-28 9:07 ` Christian Borntraeger
2013-05-28 10:44 ` Paolo Bonzini
2013-06-03 7:50 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A47231.8020001@redhat.com \
--to=pbonzini@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cornelia.huck@de.ibm.com \
--cc=gleb@redhat.com \
--cc=heiko.carstens@de.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox