From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Daney Subject: Re: [PATCH 10/18] KVM/MIPS32-VZ: Add API for VZ-ASE Capability Date: Thu, 30 May 2013 10:07:43 -0700 Message-ID: <51A7875F.4080606@gmail.com> References: <1368942460-15577-1-git-send-email-sanjayl@kymasys.com> <1368942460-15577-11-git-send-email-sanjayl@kymasys.com> <51A4DC99.7040706@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, linux-mips@linux-mips.org, Ralf Baechle , Gleb Natapov , Marcelo Tosatti To: Paolo Bonzini , Sanjay Lal Return-path: Received: from mail-pb0-f42.google.com ([209.85.160.42]:64591 "EHLO mail-pb0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758408Ab3E3RHq (ORCPT ); Thu, 30 May 2013 13:07:46 -0400 Received: by mail-pb0-f42.google.com with SMTP id uo1so715263pbc.1 for ; Thu, 30 May 2013 10:07:46 -0700 (PDT) In-Reply-To: <51A4DC99.7040706@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 05/28/2013 09:34 AM, Paolo Bonzini wrote: > Il 19/05/2013 07:47, Sanjay Lal ha scritto: >> - Add API to allow clients (QEMU etc.) to check whether the H/W >> supports the MIPS VZ-ASE. > > Why does this matter to userspace? Do the userspace have some way to > detect if the kernel is unmodified or minimally-modified? > There are (will be) two types of VM presented by MIPS KVM: 1) That provided by the initial patch where a faux-MIPS is emulated and all kernel code must be in the USEG address space. 2) Real MIPS, addressing works as per the architecture specification. Presumably the user-space client would like to know which of these are supported, as well as be able to select the desired model. I don't know the best way to do this, but I agree that KVM_CAP_MIPS_VZ_ASE is probably not the best name for it. My idea was to have the arg of the KVM_CREATE_VM ioctl specify the desired style David Daney > Paolo > >> Signed-off-by: Sanjay Lal >> --- >> include/uapi/linux/kvm.h | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h >> index a5c86fc..5889e976 100644 >> --- a/include/uapi/linux/kvm.h >> +++ b/include/uapi/linux/kvm.h >> @@ -666,6 +666,7 @@ struct kvm_ppc_smmu_info { >> #define KVM_CAP_IRQ_MPIC 90 >> #define KVM_CAP_PPC_RTAS 91 >> #define KVM_CAP_IRQ_XICS 92 >> +#define KVM_CAP_MIPS_VZ_ASE 93 >> >> #ifdef KVM_CAP_IRQ_ROUTING >> >> > > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > >