From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 06/18] KVM/MIPS32-VZ: VZ-ASE related callbacks to handle
 guest exceptions that trap to the Root context.
Date: Thu, 30 May 2013 22:11:31 +0200
Message-ID: <51A7B273.1060609@redhat.com>
References: <n> <1368942460-15577-1-git-send-email-sanjayl@kymasys.com> <1368942460-15577-7-git-send-email-sanjayl@kymasys.com> <51A4D7F8.3060300@redhat.com> <2F16EB10-AFB8-4922-BAC1-EDCED4CC540E@kymasys.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org, linux-mips@linux-mips.org,
	Ralf Baechle <ralf@linux-mips.org>,
	Gleb Natapov <gleb@redhat.com>,
	Marcelo Tosatti <mtosatti@redhat.com>
To: Sanjay Lal <sanjayl@kymasys.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-ee0-f42.google.com ([74.125.83.42]:33119 "EHLO
	mail-ee0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754232Ab3E3ULq (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 30 May 2013 16:11:46 -0400
Received: by mail-ee0-f42.google.com with SMTP id c50so40329eek.1
        for <kvm@vger.kernel.org>; Thu, 30 May 2013 13:11:45 -0700 (PDT)
In-Reply-To: <2F16EB10-AFB8-4922-BAC1-EDCED4CC540E@kymasys.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Il 30/05/2013 20:35, Sanjay Lal ha scritto:
>>> >> +#endif
>>> >> +		local_irq_save(flags);
>>> >> +		if (kvm_mips_handle_vz_root_tlb_fault(badvaddr, vcpu) < 0) {
>>> >> +			run->exit_reason = KVM_EXIT_INTERNAL_ERROR;
>>> >> +			er = EMULATE_FAIL;
>>> >> +		}
>>> >> +		local_irq_restore(flags);
>>> >> +	}
>> > 
>> > This is introduced much later.  Please make sure that, with
>> > CONFIG_KVM_MIPS_VZ, every patch builds.
>> > 
>> > Paolo
>> > 
> Again, I think this has to do with the fact that the patches were
> against 3.10-rc2, will rebase for v2.

No, this is a simple patch ordering problem.
kvm_mips_handle_vz_root_tlb_fault is added in patch 11 only.

Paolo