From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH qom-cpu 57/59] cpu: Make first_cpu and next_cpu
 CPUState (WIP)
Date: Sun, 09 Jun 2013 23:13:39 +0200
Message-ID: <51B4F003.9070005@suse.de>
References: <1370805206-26574-1-git-send-email-afaerber@suse.de> <1370805206-26574-58-git-send-email-afaerber@suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Anthony Liguori <aliguori@us.ibm.com>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	Igor Mitsyanko <i.mitsyanko@samsung.com>,
	Mark Langsdorf <mark.langsdorf@calxeda.com>,
	Evgeny Voevodin <e.voevodin@samsung.com>,
	Riku Voipio <riku.voipio@iki.fi>,
	Gleb Natapov <gleb@redhat.com>,
	Peter Crosthwaite <peter.crosthwaite@petalogix.com>,
	qemu-ppc <qemu-ppc@nongnu.org>,
	Paul Brook <paul@codesourcery.com>,
	David Gibson <david@gibson.dropbear.id.au>,
	KVM <kvm@vger.kernel.org>,
	"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
	Maksim Kozlov <m.kozlov@samsung.com>,
	Aurelien Jarno <aurelien@aurel32.net>,
	Dmitry Solodkiy <d.solodkiy@samsung.com>
To: qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>
Return-path: <kvm-owner@vger.kernel.org>
Received: from cantor2.suse.de ([195.135.220.15]:47817 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751120Ab3FIVNu (ORCPT <rfc822;kvm@vger.kernel.org>);
	Sun, 9 Jun 2013 17:13:50 -0400
In-Reply-To: <1370805206-26574-58-git-send-email-afaerber@suse.de>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Am 09.06.2013 21:13, schrieb Andreas F=C3=A4rber:
>  cpus.c                    | 15 +++++++++------
>  exec.c                    | 27 ++++++++++++++-------------
>  gdbstub.c                 | 15 ++++++++-------
>  hw/arm/boot.c             | 10 +++++-----
>  hw/arm/exynos4_boards.c   |  4 ++--
>  hw/arm/highbank.c         |  2 +-
>  hw/arm/realview.c         |  2 +-
>  hw/arm/vexpress.c         |  2 +-
>  hw/arm/xilinx_zynq.c      |  2 +-
>  hw/i386/kvm/clock.c       |  6 ++++--
>  hw/i386/kvmvapic.c        |  5 +++--
>  hw/i386/pc.c              | 11 ++++++-----
>  hw/i386/pc_piix.c         |  3 +--
>  hw/intc/sh_intc.c         |  5 ++---
>  hw/isa/lpc_ich9.c         |  2 +-
>  hw/mips/mips_malta.c      |  3 ++-
>  hw/ppc/prep.c             |  6 ++++--
>  hw/ppc/spapr.c            | 12 ++++++------
>  include/exec/cpu-all.h    |  2 +-
>  include/exec/cpu-defs.h   |  1 -
>  include/qom/cpu.h         |  2 ++
>  linux-user/main.c         |  4 ++--
>  linux-user/syscall.c      |  9 ++++++---
>  target-i386/arch_dump.c   |  7 +++++--
>  target-i386/kvm.c         |  8 +++++---
>  target-i386/misc_helper.c |  2 +-
>  26 files changed, 93 insertions(+), 74 deletions(-)

=46ound one unconverted first_cpu occurrence, breaking the ppc build:

diff --git a/target-ppc/kvm.c b/target-ppc/kvm.c
index 3ab2946..87f25ea 100644
--- a/target-ppc/kvm.c
+++ b/target-ppc/kvm.c
@@ -1574,7 +1574,7 @@ uint64_t kvmppc_rma_size(uint64_t current_size,
unsigned int hash_shift)

     /* Find the largest hardware supported page size that's less than
      * or equal to the (logical) backing page size of guest RAM */
-    kvm_get_smmu_info(ppc_env_get_cpu(first_cpu), &info);
+    kvm_get_smmu_info(POWERPC_CPU(first_cpu), &info);
     rampagesize =3D getrampagesize();
     best_page_shift =3D 0;


=46ixed on qom-cpu-10 branch.

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=
=BCrnberg