From: David Daney <david.s.daney@gmail.com>
To: Gleb Natapov <gleb@redhat.com>
Cc: David Daney <ddaney.cavm@gmail.com>,
linux-mips@linux-mips.org, ralf@linux-mips.org,
kvm@vger.kernel.org, Sanjay Lal <sanjayl@kymasys.com>,
linux-kernel@vger.kernel.org,
David Daney <david.daney@cavium.com>
Subject: Re: [PATCH v5 5/6] mips/kvm: Fix ABI by moving manipulation of CP0 registers to KVM_{G,S}ET_ONE_REG
Date: Sun, 09 Jun 2013 15:57:55 -0700 [thread overview]
Message-ID: <51B50873.8010104@gmail.com> (raw)
In-Reply-To: <20130608110503.GF15299@redhat.com>
On 06/08/2013 04:05 AM, Gleb Natapov wrote:
> On Wed, May 22, 2013 at 11:43:55AM -0700, David Daney wrote:
>> From: David Daney <david.daney@cavium.com>
>>
>> Because not all 256 CP0 registers are ever implemented, we need a
>> different method of manipulating them. Use the
>> KVM_SET_ONE_REG/KVM_GET_ONE_REG mechanism.
>>
>> Now unused code and definitions are removed.
>>
> Just noticed that KVM_REG_MIPS_ definitions are wrong. You need to
> define KVM_REG_MIPS in include/uapi/linux/kvm.h (please use
> 0x7000000000000000ULL as 0x6000000000000000ULL is reserved for ARM64)
> and define all KVM_REG_MIPS_ values as "KVM_REG_MIPS | value". Can you
> send a patch to do that ASAP?
It will have to be tomorrow, I cannot test anything today.
Thanks,
David Daney
next prev parent reply other threads:[~2013-06-09 22:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-22 18:43 [PATCH v5 0/6] mips/kvm: Fix ABI for compatibility with 64-bit guests David Daney
2013-05-22 18:43 ` [PATCH v5 1/6] mips/kvm: Fix ABI for use of FPU David Daney
2013-05-22 18:43 ` [PATCH v5 2/6] mips/kvm: Fix ABI for use of 64-bit registers David Daney
2013-05-22 18:43 ` [PATCH v5 3/6] mips/kvm: Fix name of gpr field in struct kvm_regs David Daney
2013-05-22 18:43 ` [PATCH v5 4/6] mips/kvm: Use ARRAY_SIZE() instead of hardcoded constants in kvm_arch_vcpu_ioctl_{s,g}et_regs David Daney
2013-05-22 18:43 ` [PATCH v5 5/6] mips/kvm: Fix ABI by moving manipulation of CP0 registers to KVM_{G,S}ET_ONE_REG David Daney
2013-06-08 11:05 ` Gleb Natapov
2013-06-09 22:57 ` David Daney [this message]
2013-05-22 18:43 ` [PATCH v5 6/6] mips/kvm: Use ENOIOCTLCMD to indicate unimplemented ioctls David Daney
2013-05-22 19:05 ` [PATCH v5 0/6] mips/kvm: Fix ABI for compatibility with 64-bit guests Sanjay Lal
2013-05-23 10:28 ` Gleb Natapov
2013-05-23 16:58 ` David Daney
2013-05-23 17:09 ` Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B50873.8010104@gmail.com \
--to=david.s.daney@gmail.com \
--cc=david.daney@cavium.com \
--cc=ddaney.cavm@gmail.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=sanjayl@kymasys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox