From: Paolo Bonzini <pbonzini@redhat.com>
To: "Zhanghaoyu (A)" <haoyu.zhang@huawei.com>
Cc: KVM <kvm@vger.kernel.org>, "mst@redhat.com" <mst@redhat.com>,
Luonengjun <luonengjun@huawei.com>,
Zanghongyong <zanghongyong@huawei.com>,
"Huangweidong (C)" <weidong.huang@huawei.com>,
"Wangrui (K)" <moon.wangrui@huawei.com>
Subject: Re: [PATCH] KVM: x86: remove vcpu's CPL check in host invoked vcpu's xcr set process
Date: Mon, 17 Jun 2013 17:38:50 +0200 [thread overview]
Message-ID: <51BF2D8A.10005@redhat.com> (raw)
In-Reply-To: <D3E216785288A145B7BC975F83A2ED103FEAC791@szxeml556-mbx.china.huawei.com>
Il 14/06/2013 09:36, Zhanghaoyu (A) ha scritto:
> __kvm_set_xcr function does the CPL check when set xcr. __kvm_set_xcr is called in two flows,
> one is invoked by guest, call stack shown as below,
> handle_xsetbv(or xsetbv_interception)
> kvm_set_xcr
> __kvm_set_xcr
> the other one is invoked by host(QEMU), call stack shown as below,
> kvm_arch_vcpu_ioctl
> kvm_vcpu_ioctl_x86_set_xcrs
> __kvm_set_xcr
>
> The former does need the CPL check, but the latter does not.
>
> Signed-off-by: Zhang Haoyu <haoyu.zhang@huawei.com>
What does this patch fix? I suppose it is some kind of migration
problem since you mentioned QEMU, but I'd rather be sure. I can fix the
commit message myself when applying.
Thanks,
Paolo
next prev parent reply other threads:[~2013-06-17 15:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-14 7:36 [PATCH] KVM: x86: remove vcpu's CPL check in host invoked vcpu's xcr set process Zhanghaoyu (A)
2013-06-17 15:38 ` Paolo Bonzini [this message]
2013-06-18 1:32 ` Zhanghaoyu (A)
2013-06-18 8:00 ` Paolo Bonzini
2013-06-18 12:39 ` Zhanghaoyu (A)
2013-06-18 13:34 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51BF2D8A.10005@redhat.com \
--to=pbonzini@redhat.com \
--cc=haoyu.zhang@huawei.com \
--cc=kvm@vger.kernel.org \
--cc=luonengjun@huawei.com \
--cc=moon.wangrui@huawei.com \
--cc=mst@redhat.com \
--cc=weidong.huang@huawei.com \
--cc=zanghongyong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).