From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v4 1/3] kvm-unit-tests: Add memcpy to lib/string.c
Date: Fri, 21 Jun 2013 17:01:22 +0200
Message-ID: <51C46AC2.8040900@redhat.com>
References: <1371738969-26658-1-git-send-email-yzt356@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org, gleb@redhat.com, jan.kiszka@web.de
To: Arthur Chunqi Li <yzt356@gmail.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-wg0-f45.google.com ([74.125.82.45]:36366 "EHLO
	mail-wg0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1161419Ab3FUPB1 (ORCPT <rfc822;kvm@vger.kernel.org>);
	Fri, 21 Jun 2013 11:01:27 -0400
Received: by mail-wg0-f45.google.com with SMTP id j13so6662045wgh.12
        for <kvm@vger.kernel.org>; Fri, 21 Jun 2013 08:01:25 -0700 (PDT)
In-Reply-To: <1371738969-26658-1-git-send-email-yzt356@gmail.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Il 20/06/2013 16:36, Arthur Chunqi Li ha scritto:
> Add memcpy(void *dest, const void *src, size_t n) to lib/string.c.
> This function acts the same as memcpy in libc.
> 
> Signed-off-by: Arthur Chunqi Li <yzt356@gmail.com>
> ---
>  lib/libcflat.h |    1 +
>  lib/string.c   |   12 ++++++++++++
>  2 files changed, 13 insertions(+)
> 
> diff --git a/lib/libcflat.h b/lib/libcflat.h
> index 0875bd9..fadc33d 100644
> --- a/lib/libcflat.h
> +++ b/lib/libcflat.h
> @@ -50,6 +50,7 @@ extern int vsnprintf(char *buf, int size, const char *fmt, va_list va);
>  extern void puts(const char *s);
>  
>  extern void *memset(void *s, int c, size_t n);
> +extern void *memcpy(void *dest, const void *src, size_t n);
>  
>  extern long atol(const char *ptr);
>  #define ARRAY_SIZE(_a)  (sizeof(_a)/sizeof((_a)[0]))
> diff --git a/lib/string.c b/lib/string.c
> index 9dc94a1..e798f86 100644
> --- a/lib/string.c
> +++ b/lib/string.c
> @@ -42,6 +42,18 @@ void *memset(void *s, int c, size_t n)
>      return s;
>  }
>  
> +void *memcpy(void *dest, const void *src, size_t n)
> +{
> +    size_t i;
> +    char *a = dest;
> +    char *b = src;

I added a const here and pushed the three patches.

Paolo

> +
> +    for (i = 0; i < n; ++i)
> +        a[i] = b[i];
> +
> +    return dest;
> +}
> +
>  long atol(const char *ptr)
>  {
>      long acc = 0;
>