From: Paolo Bonzini <pbonzini@redhat.com>
To: Gleb Natapov <gleb@redhat.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
Jan Kiszka <jan.kiszka@web.de>, Glauber Costa <glommer@gmail.com>,
kvm-devel <kvm@vger.kernel.org>,
qemu-devel <qemu-devel@nongnu.org>,
qemu-stable@nongnu.org
Subject: Re: [PATCH] kvmclock: clock should count only if vm is running (v2)
Date: Mon, 01 Jul 2013 13:44:42 +0200 [thread overview]
Message-ID: <51D16BAA.8050207@redhat.com> (raw)
In-Reply-To: <20130625121815.GR18508@redhat.com>
Il 25/06/2013 14:18, Gleb Natapov ha scritto:
> On Tue, Jun 18, 2013 at 08:38:25PM -0300, Marcelo Tosatti wrote:
>> >
>> > v2: remove unnecessary runstate_is_running() usage (Paolo)
>> >
>> > --
>> >
>> > kvmclock should not count while vm is paused, because:
>> >
>> > 1) if the vm is paused for long periods, timekeeping
>> > math can overflow while converting the (large) clocksource
>> > delta to nanoseconds.
>> >
>> > 2) Users rely on CLOCK_MONOTONIC to count run time, that is,
>> > time which OS has been in a runnable state (see CLOCK_BOOTTIME).
>> >
>> > Change kvmclock driver so as to save clock value when vm transitions
>> > from runnable to stopped state, and to restore clock value from stopped
>> > to runnable transition.
>> >
>> > Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
>
> Applied, thanks.
Cc: qemu-stable@nongnu.org
Gleb, the commit hash is fixed now that you applied the patch---so I
cannot just amend it to include the Cc, right?
Paolo
next prev parent reply other threads:[~2013-07-01 11:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-08 2:00 [PATCH] kvmclock: clock should count only if vm is running Marcelo Tosatti
2013-06-18 9:02 ` Paolo Bonzini
2013-06-18 23:20 ` Marcelo Tosatti
2013-06-18 23:38 ` [PATCH] kvmclock: clock should count only if vm is running (v2) Marcelo Tosatti
2013-06-25 12:18 ` Gleb Natapov
2013-07-01 11:44 ` Paolo Bonzini [this message]
2013-07-01 11:53 ` Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51D16BAA.8050207@redhat.com \
--to=pbonzini@redhat.com \
--cc=gleb@redhat.com \
--cc=glommer@gmail.com \
--cc=jan.kiszka@web.de \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox