From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH] kvmclock: clock should count only if vm is running (v2) Date: Mon, 01 Jul 2013 13:44:42 +0200 Message-ID: <51D16BAA.8050207@redhat.com> References: <20130608020048.GA1412@amt.cnet> <20130618233825.GA19042@amt.cnet> <20130625121815.GR18508@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , Jan Kiszka , Glauber Costa , kvm-devel , qemu-devel , qemu-stable@nongnu.org To: Gleb Natapov Return-path: Received: from mail-qc0-f169.google.com ([209.85.216.169]:46638 "EHLO mail-qc0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753886Ab3GALot (ORCPT ); Mon, 1 Jul 2013 07:44:49 -0400 Received: by mail-qc0-f169.google.com with SMTP id c10so2792700qcz.14 for ; Mon, 01 Jul 2013 04:44:48 -0700 (PDT) In-Reply-To: <20130625121815.GR18508@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Il 25/06/2013 14:18, Gleb Natapov ha scritto: > On Tue, Jun 18, 2013 at 08:38:25PM -0300, Marcelo Tosatti wrote: >> > >> > v2: remove unnecessary runstate_is_running() usage (Paolo) >> > >> > -- >> > >> > kvmclock should not count while vm is paused, because: >> > >> > 1) if the vm is paused for long periods, timekeeping >> > math can overflow while converting the (large) clocksource >> > delta to nanoseconds. >> > >> > 2) Users rely on CLOCK_MONOTONIC to count run time, that is, >> > time which OS has been in a runnable state (see CLOCK_BOOTTIME). >> > >> > Change kvmclock driver so as to save clock value when vm transitions >> > from runnable to stopped state, and to restore clock value from stopped >> > to runnable transition. >> > >> > Signed-off-by: Marcelo Tosatti > > Applied, thanks. Cc: qemu-stable@nongnu.org Gleb, the commit hash is fixed now that you applied the patch---so I cannot just amend it to include the Cc, right? Paolo