From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Subject: Re: [Qemu-devel] [PATCH qom-cpu v3 05/14] cpu: Make first_cpu and next_cpu CPUState Date: Mon, 01 Jul 2013 19:37:05 +0200 Message-ID: <51D1BE41.40901@suse.de> References: <1372268143-3894-1-git-send-email-afaerber@suse.de> <1372268143-3894-6-git-send-email-afaerber@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: qemu-devel@nongnu.org, Peter Maydell , Anthony Liguori , Riku Voipio , Igor Mitsyanko , Mark Langsdorf , Evgeny Voevodin , Marcelo Tosatti , Gleb Natapov , Luiz Capitulino , Peter Crosthwaite , =?UTF-8?B?QW5kcmVhcw==?= =?UTF-8?B?IEbDpHJiZXI=?= , qemu-ppc , Paul Brook , David Gibson , kvm , "Edgar E. Iglesias" , Maksim Kozlov , Aurelien Jarno , Dmitry Solodkiy To: Alexander Graf Return-path: Received: from cantor2.suse.de ([195.135.220.15]:39951 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751889Ab3GARhM (ORCPT ); Mon, 1 Jul 2013 13:37:12 -0400 In-Reply-To: <1372268143-3894-6-git-send-email-afaerber@suse.de> Sender: kvm-owner@vger.kernel.org List-ID: Am 26.06.2013 19:35, schrieb Andreas F=C3=A4rber: > Move next_cpu from CPU_COMMON to CPUState. > Move first_cpu variable to qom/cpu.h. >=20 > gdbstub needs to use CPUState::env_ptr for now. > cpu_copy() no longer needs to save and restore cpu_next. >=20 > Acked-by: Paolo Bonzini > [AF: Rebased, simplified cpu_copy()] > Signed-off-by: Andreas F=C3=A4rber Squashing the following additional conversion after rebase. Andreas diff --git a/hw/ppc/e500.c b/hw/ppc/e500.c index 38f7990..ff86154 100644 --- a/hw/ppc/e500.c +++ b/hw/ppc/e500.c @@ -500,7 +500,6 @@ static DeviceState *ppce500_init_mpic_kvm(PPCE500Params *params, qemu_irq **irqs) { DeviceState *dev; - CPUPPCState *env; CPUState *cs; int r; @@ -512,9 +511,7 @@ static DeviceState *ppce500_init_mpic_kvm(PPCE500Params *params, return NULL; } - for (env =3D first_cpu; env !=3D NULL; env =3D env->next_cpu) { - cs =3D ENV_GET_CPU(env); - + for (cs =3D first_cpu; cs !=3D NULL; cs =3D cs->next_cpu) { if (kvm_openpic_connect_vcpu(dev, cs)) { --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3= =BCrnberg