From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v4 2/2] KVM: s390: use cookies for ioeventfd
Date: Wed, 03 Jul 2013 17:30:40 +0200
Message-ID: <51D443A0.9040703@redhat.com>
References: <1372861854-23043-1-git-send-email-cornelia.huck@de.ibm.com> <1372861854-23043-3-git-send-email-cornelia.huck@de.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Cc: Gleb Natapov <gleb@redhat.com>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Heiko Carstens <heiko.carstens@de.ibm.com>,
	Martin Schwidefsky <schwidefsky@de.ibm.com>,
	KVM <kvm@vger.kernel.org>,
	linux-s390 <linux-s390@vger.kernel.org>
To: Cornelia Huck <cornelia.huck@de.ibm.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:57993 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752315Ab3GCPaz (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 3 Jul 2013 11:30:55 -0400
In-Reply-To: <1372861854-23043-3-git-send-email-cornelia.huck@de.ibm.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Il 03/07/2013 16:30, Cornelia Huck ha scritto:
> +	/*
> +	 * Return cookie in gpr 2, but don't overwrite the register if the
> +	 * diagnose will be handled by userspace.
> +	 */
> +	if (ret != -EOPNOTSUPP)
> +		vcpu->run->s.regs.gprs[2] = ret;

I think this should now be "if (ret >= 0)".

>  	/* kvm_io_bus_write returns -EOPNOTSUPP if it found no match. */

The comment is now obsolete.

>  	return ret < 0 ? ret : 0;

Otherwise looks good, thanks!

Paolo