From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xiao Guangrong Subject: Re: [PATCH 1/2] KVM: Introduce kvm_arch_memslots_updated() Date: Thu, 04 Jul 2013 18:28:03 +0800 Message-ID: <51D54E33.60708@linux.vnet.ibm.com> References: <20130704133928.85fd1aab.yoshikawa_takuya_b1@lab.ntt.co.jp> <20130704134029.4db2736a.yoshikawa_takuya_b1@lab.ntt.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: gleb@redhat.com, pbonzini@redhat.com, kvm@vger.kernel.org, agraf@suse.de, borntraeger@de.ibm.com, cornelia.huck@de.ibm.com, christoffer.dall@linaro.org To: Takuya Yoshikawa Return-path: Received: from e28smtp05.in.ibm.com ([122.248.162.5]:42592 "EHLO e28smtp05.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752011Ab3GDK2O (ORCPT ); Thu, 4 Jul 2013 06:28:14 -0400 Received: from /spool/local by e28smtp05.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 4 Jul 2013 15:52:56 +0530 Received: from d28relay01.in.ibm.com (d28relay01.in.ibm.com [9.184.220.58]) by d28dlp02.in.ibm.com (Postfix) with ESMTP id 5E35B3940043 for ; Thu, 4 Jul 2013 15:58:07 +0530 (IST) Received: from d28av04.in.ibm.com (d28av04.in.ibm.com [9.184.220.66]) by d28relay01.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r64ASXhU10354752 for ; Thu, 4 Jul 2013 15:58:34 +0530 Received: from d28av04.in.ibm.com (loopback [127.0.0.1]) by d28av04.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r64AS5qb016800 for ; Thu, 4 Jul 2013 20:28:06 +1000 In-Reply-To: <20130704134029.4db2736a.yoshikawa_takuya_b1@lab.ntt.co.jp> Sender: kvm-owner@vger.kernel.org List-ID: On 07/04/2013 12:40 PM, Takuya Yoshikawa wrote: > This is called right after the memslots is updated, i.e. when the result > of update_memslots() gets installed in install_new_memslots(). Since > the memslots needs to be updated twice when we delete or move a memslot, > kvm_arch_commit_memory_region() does not correspond to this exactly. > > In the following patch, x86 will use this new API to check if the mmio > generation has reached its maximum value, in which case mmio sptes need > to be flushed out. Reviewed-by: Xiao Guangrong