Re: [PATCH v4 0/2] Basic nested VMX test suite

[Paolo Bonzini <pbonzini@redhat.com>]

Il 17/07/2013 12:31, Gleb Natapov ha scritto:
> On Wed, Jul 17, 2013 at 12:19:32PM +0200, Paolo Bonzini wrote:
>> Il 17/07/2013 11:03, Gleb Natapov ha scritto:
>>> This is not about taste, this is about hackability of the code. I will maintain it
>>> and I want it to be as simple as possible given task it does. Looking similar to KVM
>>> is additional bonus because the code will naturally look familiar to KVM maintainer.
>>
>> Then you may just as well write it yourself, no?
>
> What the point of the question? That may apply to any comment of any
> reviewer if it does not point to a bug. So if it compiles - apply it?

"Looking similar to KVM" is not an interesting property when writing a
completely separate body of code.

If we want to optimize for familiarity to the KVM maintainer, the best
way to do that is to only have the KVM maintainer write code.

> If you do it right there will be _not point in doing_ global jumps. The
> control flow will be linear, the code will be much more readable.

Ok, let's see what Arthur comes up with.

Paolo