Re: [PATCH 1/4] x86: introduce hypervisor_cpuid_base()

Jason Wang
2013-07-24T04:44:30Z

On 07/24/2013 12:03 AM, H. Peter Anvin wrote:
> On 07/23/2013 04:16 AM, Paolo Bonzini wrote:
>> That's nicer, though strcmp is what the replaced code used to do in
>> patches 2 and 3.
>>
>> Note that memcmp requires the caller to use "KVMKVMKVM\0\0" as the
>> signature (or alternatively hypervisor_cpuid_base can copy the argument
>> into another 12-byte local variable).
>>
> Which is the actual signature, though...
>
> -hpa
>
>

Since it's just a minor optimization. How about just keep using the
strcmp()?