From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v4 01/13] nEPT: Support LOAD_IA32_EFER entry/exit controls
 for L1
Date: Mon, 29 Jul 2013 16:13:42 +0200
Message-ID: <51F67896.8090109@redhat.com>
References: <1374750001-28527-1-git-send-email-gleb@redhat.com> <1374750001-28527-2-git-send-email-gleb@redhat.com> <51F628BA.7040209@redhat.com> <20130729131203.GJ18009@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org,
	Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>,
	Jun Nakajima <jun.nakajima@intel.com>,
	Yang Zhang <yang.z.zhang@intel.com>
To: Gleb Natapov <gleb@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:12237 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751112Ab3G2OPG (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 29 Jul 2013 10:15:06 -0400
In-Reply-To: <20130729131203.GJ18009@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Il 29/07/2013 15:12, Gleb Natapov ha scritto:
>> Il 25/07/2013 12:59, Gleb Natapov ha scritto:
>>> > > +	 * we should use its exit controls. Note that IA32_MODE, LOAD_IA32_EFER
>>> > > +	 * bits are further modified by vmx_set_efer() below.
>> > 
>> > IA32E_MODE, but the last sentence is not relevant anyway for this
>> > vmcs_write32; in fact, the next command basically duplicates it.
>> > 
> IA32E_MODE is not relevant, it never changes in VM_EXIT_CONTROLS, but
> LOAD_IA32_EFER refers to VM_EXIT_LOAD_IA32_EFER, which can be set by
> vmx_set_efer() and is different from VM_ENTRY_LOAD_IA32_EFER that
> comment bellow talks about.
> 

Yes.  Just fix the comment so that it is clear.

Paolo