From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marc Zyngier <marc.zyngier@arm.com>
Subject: Re: [PATCH] ARM64: include: asm: use 'int' instead of 'u32' for variable
 'target' in kvm_host.h.
Date: Tue, 30 Jul 2013 08:41:34 +0100
Message-ID: <51F76E2E.9050707@arm.com>
References: <51ECA9B6.3010808@asianux.com> <20130730034945.GD5471@cbox>
Mime-Version: 1.0
Content-Type: text/plain; charset=WINDOWS-1252
Content-Transfer-Encoding: 8BIT
Cc: Chen Gang <gang.chen@asianux.com>, Gleb Natapov <gleb@redhat.com>,
	"pbonzini@redhat.com" <pbonzini@redhat.com>,
	Catalin Marinas <Catalin.Marinas@arm.com>,
	Will Deacon <Will.Deacon@arm.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>
To: Christoffer Dall <christoffer.dall@linaro.org>
Return-path: <kvm-owner@vger.kernel.org>
Received: from service87.mimecast.com ([91.220.42.44]:48907 "EHLO
	service87.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753079Ab3G3Hlk convert rfc822-to-8bit (ORCPT
	<rfc822;kvm@vger.kernel.org>); Tue, 30 Jul 2013 03:41:40 -0400
In-Reply-To: <20130730034945.GD5471@cbox>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 30/07/13 04:49, Christoffer Dall wrote:
> On Mon, Jul 22, 2013 at 11:40:38AM +0800, Chen Gang wrote:
>> 'target' will be set to '-1' in kvm_arch_vcpu_init(), and it need check
>> 'target' whether less than zero or not in kvm_vcpu_initialized().
>>
>> So need define target as 'int' instead of 'u32', just like ARM has done.
>>
>>
>> The related warning:
>>
>>   arch/arm64/kvm/../../../arch/arm/kvm/arm.c:497:2: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
>>
>> Signed-off-by: Chen Gang <gang.chen@asianux.com>
>> ---
>>  arch/arm64/include/asm/kvm_host.h |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/arm64/include/asm/kvm_host.h b/arch/arm64/include/asm/kvm_host.h
>> index 644d739..0859a4d 100644
>> --- a/arch/arm64/include/asm/kvm_host.h
>> +++ b/arch/arm64/include/asm/kvm_host.h
>> @@ -129,7 +129,7 @@ struct kvm_vcpu_arch {
>>  	struct kvm_mmu_memory_cache mmu_page_cache;
>>  
>>  	/* Target CPU and feature flags */
>> -	u32 target;
>> +	int target;
>>  	DECLARE_BITMAP(features, KVM_VCPU_MAX_FEATURES);
>>  
>>  	/* Detect first run of a vcpu */
>> -- 
>> 1.7.7.6
> 
> This looks ok to me, Marc, was there any reason to declare target a u32
> on arm64?

No, that's simply a bug. I really wonder why my compiler doesn't scream
at something that obvious...

Chen: what compiler version are you using?

I'll queue this fix.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...