From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH] KVM: nVMX: Advertise IA32_PAT in VM exit control Date: Mon, 05 Aug 2013 12:38:32 +0200 Message-ID: <51FF80A8.5000309@web.de> References: <1375693835-10988-1-git-send-email-yzt356@gmail.com> <20130805093349.GI2258@redhat.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ibp8FFL9GK1OBvPlbFnE9oe4vRLlbPPGA" Cc: Gleb Natapov , "kvm@vger.kernel.org" , "pbonzini@redhat.com" To: Gmail Return-path: Received: from mout.web.de ([212.227.15.4]:54474 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754389Ab3HEKif (ORCPT ); Mon, 5 Aug 2013 06:38:35 -0400 Received: from mchn199C.mchp.siemens.de ([95.157.58.223]) by smtp.web.de (mrweb001) with ESMTPSA (Nemesis) id 0MDgPG-1UpJH50yx4-00H6Vv for ; Mon, 05 Aug 2013 12:38:33 +0200 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ibp8FFL9GK1OBvPlbFnE9oe4vRLlbPPGA Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 2013-08-05 11:36, Gmail wrote: >=20 >=20 >> On Mon, Aug 05, 2013 at 05:10:35PM +0800, Arthur Chunqi Li wrote: >>> Advertise VM_EXIT_SAVE_IA32_PAT and VM_EXIT_LOAD_IA32_PAT. >>> >>> Signed-off-by: Arthur Chunqi Li >>> --- >>> arch/x86/kvm/vmx.c | 3 ++- >>> 1 file changed, 2 insertions(+), 1 deletion(-) >>> >>> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c >>> index 45fd70c..240f0db 100644 >>> --- a/arch/x86/kvm/vmx.c >>> +++ b/arch/x86/kvm/vmx.c >>> @@ -2198,7 +2198,8 @@ static __init void nested_vmx_setup_ctls_msrs(v= oid) >>> #else >>> nested_vmx_exit_ctls_high =3D 0; >>> #endif >>> - nested_vmx_exit_ctls_high |=3D VM_EXIT_ALWAYSON_WITHOUT_TRUE_MSR= ; >>> + nested_vmx_exit_ctls_high |=3D VM_EXIT_ALWAYSON_WITHOUT_TRUE_MSR= | >>> + VM_EXIT_LOAD_IA32_PAT | VM_EXIT_SAVE_IA32_PAT; >>> >> You should not set those if host does not support them, otherwise >> GUEST_IA32_PAT may not be available > To Jan, > Is this different from IA32_EFER? As we use a real VMCS to keep GUEST/HOST_IA32_EFER, we actually do depend on the existence of the host feature. So my patch requires an update as you noted. Jan --ibp8FFL9GK1OBvPlbFnE9oe4vRLlbPPGA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEARECAAYFAlH/gKgACgkQitSsb3rl5xStbACg3B4JkkGJEL444GzCpztP6er4 cg0AnjZ4ceHI1GnoVPk0u9VkV9pT5TuC =U80o -----END PGP SIGNATURE----- --ibp8FFL9GK1OBvPlbFnE9oe4vRLlbPPGA--