From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH] KVM: nVMX: Advertise IA32_PAT in VM exit control Date: Mon, 05 Aug 2013 13:04:25 +0200 Message-ID: <51FF86B9.4010303@web.de> References: <1375693835-10988-1-git-send-email-yzt356@gmail.com> <20130805093349.GI2258@redhat.com> <51FF80A8.5000309@web.de> <20130805105500.GA10891@redhat.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="U5tVP4IAh6Q10wUBfp2UDkbdnsmT9w5sg" Cc: Gleb Natapov , "kvm@vger.kernel.org" , "pbonzini@redhat.com" To: Arthur Chunqi Li Return-path: Received: from mout.web.de ([212.227.15.4]:49444 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754338Ab3HELE2 (ORCPT ); Mon, 5 Aug 2013 07:04:28 -0400 Received: from mchn199C.mchp.siemens.de ([95.157.58.223]) by smtp.web.de (mrweb002) with ESMTPSA (Nemesis) id 0LmcN9-1UW8YT3HUJ-00aCsK for ; Mon, 05 Aug 2013 13:04:27 +0200 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --U5tVP4IAh6Q10wUBfp2UDkbdnsmT9w5sg Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 2013-08-05 13:00, Arthur Chunqi Li wrote: > On Mon, Aug 5, 2013 at 6:55 PM, Gleb Natapov wrote: >> On Mon, Aug 05, 2013 at 12:38:32PM +0200, Jan Kiszka wrote: >>> On 2013-08-05 11:36, Gmail wrote: >>>> >>>> >>>>> On Mon, Aug 05, 2013 at 05:10:35PM +0800, Arthur Chunqi Li wrote: >>>>>> Advertise VM_EXIT_SAVE_IA32_PAT and VM_EXIT_LOAD_IA32_PAT. >>>>>> >>>>>> Signed-off-by: Arthur Chunqi Li >>>>>> --- >>>>>> arch/x86/kvm/vmx.c | 3 ++- >>>>>> 1 file changed, 2 insertions(+), 1 deletion(-) >>>>>> >>>>>> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c >>>>>> index 45fd70c..240f0db 100644 >>>>>> --- a/arch/x86/kvm/vmx.c >>>>>> +++ b/arch/x86/kvm/vmx.c >>>>>> @@ -2198,7 +2198,8 @@ static __init void nested_vmx_setup_ctls_msr= s(void) >>>>>> #else >>>>>> nested_vmx_exit_ctls_high =3D 0; >>>>>> #endif >>>>>> - nested_vmx_exit_ctls_high |=3D VM_EXIT_ALWAYSON_WITHOUT_TRUE_= MSR; >>>>>> + nested_vmx_exit_ctls_high |=3D VM_EXIT_ALWAYSON_WITHOUT_TRUE_= MSR | >>>>>> + VM_EXIT_LOAD_IA32_PAT | VM_EXIT_SAVE_IA32_PAT; >>>>>> >>>>> You should not set those if host does not support them, otherwise >>>>> GUEST_IA32_PAT may not be available >>>> To Jan, >>>> Is this different from IA32_EFER? >>> >>> As we use a real VMCS to keep GUEST/HOST_IA32_EFER, we actually do >>> depend on the existence of the host feature. So my patch requires an >>> update as you noted. >>> >> Your patch didn't add new users of GUEST_IA32_PAT and >> VM_ENTRY_LOAD_IA32_PAT is enabled by nested only if host has it, so I = am >> not sure why you are saying that patch should be updated. > I think Jan points [1] and you refer to another. >=20 > [1] http://www.mail-archive.com/kvm@vger.kernel.org/msg94188.html Yep, that's what I was referring to. Jan --U5tVP4IAh6Q10wUBfp2UDkbdnsmT9w5sg Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEARECAAYFAlH/hroACgkQitSsb3rl5xQEUwCeLEE11XnNI+Vd4WoyHVFQW6jv zYgAn1kxkie+zTr53//sJtDTc9YpQVy+ =koAP -----END PGP SIGNATURE----- --U5tVP4IAh6Q10wUBfp2UDkbdnsmT9w5sg--