From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Daney Subject: Re: [PATCH] kvm: Make kvm_rebooting visible Date: Mon, 05 Aug 2013 15:35:05 -0700 Message-ID: <52002899.6060209@gmail.com> References: <1375740747-7769-1-git-send-email-andi@firstfloor.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: gleb@redhat.com, kvm@vger.kernel.org, pbonzini@redhat.com, Linux Kernel Mailing List To: Andi Kleen , Andi Kleen Return-path: In-Reply-To: <1375740747-7769-1-git-send-email-andi@firstfloor.org> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 08/05/2013 03:12 PM, Andi Kleen wrote: > From: Andi Kleen > > kvm_rebooting is referenced from assembler code, thus > needs to be visible. > > Signed-off-by: Andi Kleen > --- > virt/kvm/kvm_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > index 1580dd4..eff6abd 100644 > --- a/virt/kvm/kvm_main.c > +++ b/virt/kvm/kvm_main.c > @@ -95,7 +95,7 @@ static void hardware_disable_all(void); > > static void kvm_io_bus_destroy(struct kvm_io_bus *bus); > > -bool kvm_rebooting; > +__visible bool kvm_rebooting; > EXPORT_SYMBOL_GPL(kvm_rebooting); How many of these are there kernel wide? Could you do something like this instead: DEFINE_AND_EXPORT_GPL(bool, kvm_rebooting); The definition of DEFINE_AND_EXPORT_GPL(_type, _name) is left as an exercise for the reader. David Daney