From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH] ARM: KVM: Simplify tracepoint text Date: Sat, 10 Aug 2013 23:47:25 +0400 Message-ID: <520698CD.2070904@cogentembedded.com> References: <1376019686-19301-1-git-send-email-christoffer.dall@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvmarm@lists.cs.columbia.edu, linaro-kernel@lists.linaro.org, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, patches@linaro.org To: Christoffer Dall Return-path: Received: from mail-la0-f45.google.com ([209.85.215.45]:38624 "EHLO mail-la0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754335Ab3HJTrQ (ORCPT ); Sat, 10 Aug 2013 15:47:16 -0400 Received: by mail-la0-f45.google.com with SMTP id fj20so3802428lab.32 for ; Sat, 10 Aug 2013 12:47:14 -0700 (PDT) In-Reply-To: <1376019686-19301-1-git-send-email-christoffer.dall@linaro.org> Sender: kvm-owner@vger.kernel.org List-ID: Hello. On 08/09/2013 07:41 AM, Christoffer Dall wrote: > The tracepoint for kvm_guest_fault was extremely long, make it a > slightly bit shorter. > Signed-off-by: Christoffer Dall > --- > arch/arm/kvm/trace.h | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > diff --git a/arch/arm/kvm/trace.h b/arch/arm/kvm/trace.h > index a8e73ed..8cbaea2 100644 > --- a/arch/arm/kvm/trace.h > +++ b/arch/arm/kvm/trace.h > @@ -59,10 +59,9 @@ TRACE_EVENT(kvm_guest_fault, > __entry->ipa = ipa; > ), > > - TP_printk("guest fault at PC %#08lx (hxfar %#08lx, " > - "ipa %#16llx, hsr %#08lx", > - __entry->vcpu_pc, __entry->hxfar, > - __entry->ipa, __entry->hsr) > + TP_printk("ipa 0x%llx, hsr 0x%#08lx, hxfar 0x%#08lx, pc 0x%#08lx", "0x" and "#" are redundant, they mean the same thing, hexadecimal prefix. WBR, Sergei