From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH uq/master] kvm: Simplify kvm_handle_io
Date: Tue, 20 Aug 2013 18:40:19 +0200
Message-ID: <52139BF3.7000609@redhat.com>
References: <520A2A0D.4010600@siemens.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: Gleb Natapov <gleb@redhat.com>, qemu-devel <qemu-devel@nongnu.org>,
	kvm <kvm@vger.kernel.org>
To: Jan Kiszka <jan.kiszka@siemens.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-wi0-f169.google.com ([209.85.212.169]:45035 "EHLO
	mail-wi0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751194Ab3HTQlB (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 20 Aug 2013 12:41:01 -0400
Received: by mail-wi0-f169.google.com with SMTP id f14so5103918wiw.0
        for <kvm@vger.kernel.org>; Tue, 20 Aug 2013 09:41:00 -0700 (PDT)
In-Reply-To: <520A2A0D.4010600@siemens.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Il 13/08/2013 14:43, Jan Kiszka ha scritto:
> Now that cpu_in/out is just a wrapper around address_space_rw, we can
> also call the latter directly. As host endianness == guest endianness,
> there is no need for the memory access helpers st*_p/ld*_p as well.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  kvm-all.c |   28 ++--------------------------
>  1 files changed, 2 insertions(+), 26 deletions(-)
> 
> diff --git a/kvm-all.c b/kvm-all.c
> index 716860f..c861354 100644
> --- a/kvm-all.c
> +++ b/kvm-all.c
> @@ -1499,32 +1499,8 @@ static void kvm_handle_io(uint16_t port, void *data, int direction, int size,
>      uint8_t *ptr = data;
>  
>      for (i = 0; i < count; i++) {
> -        if (direction == KVM_EXIT_IO_IN) {
> -            switch (size) {
> -            case 1:
> -                stb_p(ptr, cpu_inb(port));
> -                break;
> -            case 2:
> -                stw_p(ptr, cpu_inw(port));
> -                break;
> -            case 4:
> -                stl_p(ptr, cpu_inl(port));
> -                break;
> -            }
> -        } else {
> -            switch (size) {
> -            case 1:
> -                cpu_outb(port, ldub_p(ptr));
> -                break;
> -            case 2:
> -                cpu_outw(port, lduw_p(ptr));
> -                break;
> -            case 4:
> -                cpu_outl(port, ldl_p(ptr));
> -                break;
> -            }
> -        }
> -
> +        address_space_rw(&address_space_io, port, ptr, size,
> +                         direction == KVM_EXIT_IO_OUT);
>          ptr += size;
>      }
>  }
> 

Applied, thanks.

Paolo