From mboxrd@z Thu Jan  1 00:00:00 1970
From: James Hogan <james.hogan@imgtec.com>
Subject: Re: [PATCH] kvm: sync cpu state on internal error before dump
Date: Fri, 23 Aug 2013 14:41:13 +0100
Message-ID: <52176679.6020006@imgtec.com>
References: <1377260760-32056-1-git-send-email-james.hogan@imgtec.com> <20130823125846.GE15513@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
Cc: <qemu-devel@nongnu.org>, Paolo Bonzini <pbonzini@redhat.com>,
	<kvm@vger.kernel.org>
To: Gleb Natapov <gleb@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from multi.imgtec.com ([194.200.65.239]:18592 "EHLO multi.imgtec.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1755521Ab3HWNlS (ORCPT <rfc822;kvm@vger.kernel.org>);
	Fri, 23 Aug 2013 09:41:18 -0400
In-Reply-To: <20130823125846.GE15513@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 23/08/13 13:58, Gleb Natapov wrote:
> On Fri, Aug 23, 2013 at 01:26:00PM +0100, James Hogan wrote:
>> When a KVM internal error occurs QEMU dumps the CPU state, however it
>> doesn't synchronise the state from KVM first so the dumped state is out
>> of date. Add the synchronisation calls before the dump in both locations
>> (which is used depends on whether the arch says to stop or not).
>>
> x86_cpu_dump_state() calls cpu_synchronize_state() already.

Ah yes, thanks. I hadn't noticed that.

Out of the arches that support KVM only x86 and ppc call it. arm, mips
(qemu support not upstream yet), and s390 don't. s390 never seems to
emit that exit code, and arm only does so for unsupported exceptions
(which should never happen).

I'll fix in mips_cpu_dump_state() instead.

Cheers
James