From: Marc Zyngier <marc.zyngier@arm.com>
To: Pekka Enberg <penberg@iki.fi>
Cc: Jonathan Austin <Jonathan.Austin@arm.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"penberg@kernel.org" <penberg@kernel.org>,
Will Deacon <Will.Deacon@arm.com>,
Matt Evans <Matt.Evans@arm.com>
Subject: Re: [PATCH 0/3] kvm tools: remove periodic tick
Date: Wed, 04 Sep 2013 10:58:26 +0100 [thread overview]
Message-ID: <52270442.2010605@arm.com> (raw)
In-Reply-To: <5226FC02.4060404@iki.fi>
On 04/09/13 10:23, Pekka Enberg wrote:
Hi Pekka,
> On 9/3/13 9:10 PM, Jonathan Austin wrote:
>> This patch series removes kvm tool's periodic tick function in favour of a
>> thread that blocks waiting for input. The paths used for handling input are the
>> same as when using a periodic tick, but they're not called unless there is
>> actually input to be processed.
>>
>> On extremely slow platforms (eg FPGAs) the overhead involved in handling the
>> timer tick means it is possible to make progress at all inside the VM! This
>> patch addresses this problem.
>>
>> In doing this there are a number of small tidyups/cleanups that made sense, too:
>> - Use a #define for maximum number of term devices
>> - Refactor the method by which the virtio console handles input in order not to
>> - handle input too early
>> - handle input multiple times if the worker thread didn't immediately start
>> work.
>> - Rename the periodic_poll function to reflect the functional change
>>
>> Jonathan Austin (3):
>> kvm tools: use #define for maximum number of terminal devices
>> kvm tools: remove periodic tick in favour of a polling thread
>> kvm tools: stop virtio console doing unnecessary input handling
>>
>> tools/kvm/arm/kvm.c | 2 +-
>> tools/kvm/builtin-run.c | 13 -----------
>> tools/kvm/include/kvm/kvm.h | 2 +-
>> tools/kvm/kvm.c | 50 -------------------------------------------
>> tools/kvm/powerpc/kvm.c | 2 +-
>> tools/kvm/term.c | 38 +++++++++++++++++++++++++++++---
>> tools/kvm/virtio/console.c | 23 +++++++++++++++++---
>> tools/kvm/x86/kvm.c | 2 +-
>> 8 files changed, 59 insertions(+), 73 deletions(-)
>
> Seems reasonable to me. Marc, Will?
With the nits I mentioned earlier addressed, I'm happy to give my
"Acked-by: Marc Zyngier <marc.zyngier@arm.com>".
I must also mention than I've been using an earlier version of this
patch series, and that my test rig has been much happier since... ;-)
Cheers,
M.
--
Jazz is not dead. It just smells funny...
prev parent reply other threads:[~2013-09-04 9:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-03 18:10 [PATCH 0/3] kvm tools: remove periodic tick Jonathan Austin
2013-09-03 18:10 ` [PATCH 1/3] kvm tools: use #define for maximum number of terminal devices Jonathan Austin
2013-09-03 18:10 ` [PATCH 2/3] kvm tools: remove periodic tick in favour of a polling thread Jonathan Austin
2013-09-04 9:48 ` Marc Zyngier
2013-09-03 18:10 ` [PATCH 3/3] kvm tools: stop virtio console doing unnecessary input handling Jonathan Austin
2013-09-04 9:23 ` [PATCH 0/3] kvm tools: remove periodic tick Pekka Enberg
2013-09-04 9:58 ` Marc Zyngier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52270442.2010605@arm.com \
--to=marc.zyngier@arm.com \
--cc=Jonathan.Austin@arm.com \
--cc=Matt.Evans@arm.com \
--cc=Will.Deacon@arm.com \
--cc=kvm@vger.kernel.org \
--cc=penberg@iki.fi \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox