From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christian Borntraeger Subject: Re: [PATCH v2 0/2] KVM: s390: add floating irq controller Date: Fri, 06 Sep 2013 15:30:38 +0200 Message-ID: <5229D8FE.90807@de.ibm.com> References: <1378469957-62290-1-git-send-email-jfrei@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Jens Freimann , Cornelia Huck , Alexander Graf , kvm@vger.kernel.org, qemu-devel@nongnu.org, Andreas Faerber , Thomas Huth , Peter Maydell , Christoffer Dall To: Gleb Natapov Return-path: Received: from e06smtp17.uk.ibm.com ([195.75.94.113]:56006 "EHLO e06smtp17.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750704Ab3IFNao (ORCPT ); Fri, 6 Sep 2013 09:30:44 -0400 Received: from /spool/local by e06smtp17.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 6 Sep 2013 14:25:27 +0100 Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 5304617D8059 for ; Fri, 6 Sep 2013 14:30:45 +0100 (BST) Received: from d06av09.portsmouth.uk.ibm.com (d06av09.portsmouth.uk.ibm.com [9.149.37.250]) by b06cxnps3074.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r86DUSF946989406 for ; Fri, 6 Sep 2013 13:30:28 GMT Received: from d06av09.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av09.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id r86DUdXs029455 for ; Fri, 6 Sep 2013 07:30:40 -0600 In-Reply-To: <1378469957-62290-1-git-send-email-jfrei@linux.vnet.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: On 06/09/13 14:19, Jens Freimann wrote:> This series adds a kvm_device that acts as a irq controller for floating > interrupts. As a first step it implements functionality to retrieve and inject > interrupts for the purpose of migration and for hardening the reset code by > allowing user space to explicitly remove all pending floating interrupts. > > PFAULT patches will also use this device for enabling/disabling pfault, therefore > the pfault patch series will be reworked to use this device. > > * Patch 1/2 adds a new data structure to hold interrupt information. The current > one (struct kvm_s390_interrupt) does not allow to inject every kind of interrupt, > e.g. some data for program interrupts and machine check interruptions were > missing. > > * Patch 2/2 adds a kvm_device which supports getting/setting currently pending > floating interrupts as well as deleting all currently pending interrupts > > > Jens Freimann (2): > KVM: s390: add and extend interrupt information data structs > KVM: s390: add floating irq controller > > Documentation/virtual/kvm/devices/s390_flic.txt | 36 +++ > arch/s390/include/asm/kvm_host.h | 35 +-- > arch/s390/include/uapi/asm/kvm.h | 5 + > arch/s390/kvm/interrupt.c | 304 ++++++++++++++++++++---- > arch/s390/kvm/kvm-s390.c | 1 + > include/linux/kvm_host.h | 1 + > include/uapi/linux/kvm.h | 65 +++++ > virt/kvm/kvm_main.c | 5 + > 8 files changed, 368 insertions(+), 84 deletions(-) > create mode 100644 Documentation/virtual/kvm/devices/s390_flic.txt > Gleb, Paolo, since the qemu part relies on a kernel header file, it makes sense to not only let the kernel part go via the kvm tree, but also the qemu part. I want Alex to Ack the interface, and if he agrees then I am fine with applying the whole series. If nothing else comes up, feel free to apply the small change request from Peter yourself or ask Jens for a resend. ------snip---- --- a/include/uapi/linux/kvm.h +++ b/include/uapi/linux/kvm.h @@ -908,7 +908,7 @@ struct kvm_device_attr { #define KVM_DEV_TYPE_FSL_MPIC_20 1 #define KVM_DEV_TYPE_FSL_MPIC_42 2 #define KVM_DEV_TYPE_XICS 3 -#define KVM_DEV_TYPE_FLIC 4 +#define KVM_DEV_TYPE_FLIC 5 /* * ioctls for VM fds ------snip----