From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH 4/4] KVM: nVMX: Do not generate #DF if #PF happens during exception delivery into L2 Date: Wed, 25 Sep 2013 15:53:47 +0200 Message-ID: <5242EAEB.1040700@redhat.com> References: <1380102696-25267-1-git-send-email-gleb@redhat.com> <1380102696-25267-5-git-send-email-gleb@redhat.com> <5242C801.1030100@redhat.com> <20130925115127.GI1445@redhat.com> <5242D229.6010307@redhat.com> <20130925122144.GK1445@redhat.com> <5242E4A0.50301@redhat.com> <20130925133642.GB30317@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, Marcelo Tosatti , Jan Kiszka , Alexander Graf To: Gleb Natapov Return-path: Received: from mx1.redhat.com ([209.132.183.28]:50994 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754988Ab3IYNxg (ORCPT ); Wed, 25 Sep 2013 09:53:36 -0400 In-Reply-To: <20130925133642.GB30317@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Il 25/09/2013 15:36, Gleb Natapov ha scritto: >> > I'm asking because I didn't find any other place that modifies function >> > pointers this way after kvm_mmu_reset_context. >> > > nested_ept_init_mmu_context() modify the pointer. Not after > kvm_mmu_reset_context() but it does not matter much. The canonical way > to do what I did here would be to create special mmu context to handle > shadow on shadow, bit the only difference between it and regular shadow > one would be this pointer, so it looked like overkill. Just changing the > pointer do the trick. Ok, I think it's possible to clean up the code a bit but I can do that on top of your patches. Paolo