From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH 3/4] KVM: nVMX: Check all exceptions for intercept during delivery to L2 Date: Wed, 25 Sep 2013 16:00:16 +0200 Message-ID: <5242EC70.6010003@redhat.com> References: <1380102696-25267-1-git-send-email-gleb@redhat.com> <1380102696-25267-4-git-send-email-gleb@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Gleb Natapov Return-path: Received: from mail-qa0-f45.google.com ([209.85.216.45]:41609 "EHLO mail-qa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755270Ab3IYOAB (ORCPT ); Wed, 25 Sep 2013 10:00:01 -0400 Received: by mail-qa0-f45.google.com with SMTP id k4so3443401qaq.11 for ; Wed, 25 Sep 2013 07:00:01 -0700 (PDT) In-Reply-To: <1380102696-25267-4-git-send-email-gleb@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Il 25/09/2013 11:51, Gleb Natapov ha scritto: > All exceptions should be checked for intercept during delivery to L2, > but we check only #PF currently. Drop nested_run_pending while we are > at it since exception cannot be injected during vmentry anyway. > > Signed-off-by: Gleb Natapov > --- > arch/x86/kvm/vmx.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c > index 663bc5e..5bfa09d 100644 > --- a/arch/x86/kvm/vmx.c > +++ b/arch/x86/kvm/vmx.c > @@ -1902,12 +1902,11 @@ static void skip_emulated_instruction(struct kvm_vcpu *vcpu) > * a #PF exception (this is the only case in which KVM injects a #PF when L2 > * is running). > */ > -static int nested_pf_handled(struct kvm_vcpu *vcpu) > +static int nested_ex_handled(struct kvm_vcpu *vcpu, unsigned nr) > { > struct vmcs12 *vmcs12 = get_vmcs12(vcpu); > > - /* TODO: also check PFEC_MATCH/MASK, not just EB.PF. */ Just one more question, why drop this comment? It doesn't seem incorrect in the particular case where nr == PF_VECTOR. > - if (!(vmcs12->exception_bitmap & (1u << PF_VECTOR))) > + if (!(vmcs12->exception_bitmap & (1u << nr))) > return 0; > > nested_vmx_vmexit(vcpu); > @@ -1921,8 +1920,7 @@ static void vmx_queue_exception(struct kvm_vcpu *vcpu, unsigned nr, > struct vcpu_vmx *vmx = to_vmx(vcpu); > u32 intr_info = nr | INTR_INFO_VALID_MASK; > > - if (!reinject && nr == PF_VECTOR && is_guest_mode(vcpu) && > - !vmx->nested.nested_run_pending && nested_pf_handled(vcpu)) > + if (!reinject && is_guest_mode(vcpu) && nested_ex_handled(vcpu, nr)) > return; > > if (has_error_code) { >