From: Paolo Bonzini <pbonzini@redhat.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: anthony@codemonkey.ws, aik@ozlabs.ru, qemu-devel@nongnu.org,
kvm@vger.kernel.org
Subject: Re: [PULL 3/6] vfio-pci: Lazy PCI option ROM loading
Date: Thu, 03 Oct 2013 20:46:20 +0200 [thread overview]
Message-ID: <524DBB7C.2080804@redhat.com> (raw)
In-Reply-To: <20131003153902.26487.60908.stgit@bling.home>
Il 03/10/2013 17:39, Alex Williamson ha scritto:
> +static const MemoryRegionOps vfio_rom_ops = {
> + .read = vfio_rom_read,
> + .endianness = DEVICE_LITTLE_ENDIAN,
> +};
> +
I think you need to define a write callback too (unless you're sure for
some other reason that the area will never be loaded).
Paolo
next prev parent reply other threads:[~2013-10-03 18:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-03 15:38 [PULL 0/6] VFIO updates for QEMU Alex Williamson
2013-10-03 15:38 ` [PULL 1/6] vfio-pci: Add support for MSI affinity Alex Williamson
2013-10-03 15:38 ` [PULL 2/6] vfio-pci: Test device reset capabilities Alex Williamson
2013-10-03 15:39 ` [PULL 3/6] vfio-pci: Lazy PCI option ROM loading Alex Williamson
2013-10-03 18:46 ` Paolo Bonzini [this message]
2013-10-03 19:11 ` Alex Williamson
2013-10-04 12:13 ` Alexey Kardashevskiy
2013-10-04 14:30 ` Alex Williamson
2013-10-03 15:39 ` [PULL 4/6] vfio-pci: Cleanup error_reports Alex Williamson
2013-10-03 15:39 ` [PULL 5/6] vfio-pci: Implement PCI hot reset Alex Williamson
2013-10-03 15:39 ` [PULL 6/6] vfio: Fix debug output for int128 values Alex Williamson
2013-10-09 14:54 ` [PULL 0/6] VFIO updates for QEMU Anthony Liguori
2013-10-09 15:14 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=524DBB7C.2080804@redhat.com \
--to=pbonzini@redhat.com \
--cc=aik@ozlabs.ru \
--cc=alex.williamson@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).