From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PULL 3/6] vfio-pci: Lazy PCI option ROM loading
Date: Thu, 03 Oct 2013 20:46:20 +0200
Message-ID: <524DBB7C.2080804@redhat.com>
References: <20131003153601.26487.70022.stgit@bling.home> <20131003153902.26487.60908.stgit@bling.home>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: anthony@codemonkey.ws, aik@ozlabs.ru, qemu-devel@nongnu.org,
	kvm@vger.kernel.org
To: Alex Williamson <alex.williamson@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-ee0-f53.google.com ([74.125.83.53]:50278 "EHLO
	mail-ee0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754927Ab3JCSqC (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 3 Oct 2013 14:46:02 -0400
Received: by mail-ee0-f53.google.com with SMTP id b15so1332645eek.12
        for <kvm@vger.kernel.org>; Thu, 03 Oct 2013 11:46:01 -0700 (PDT)
In-Reply-To: <20131003153902.26487.60908.stgit@bling.home>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Il 03/10/2013 17:39, Alex Williamson ha scritto:
> +static const MemoryRegionOps vfio_rom_ops = {
> +    .read = vfio_rom_read,
> +    .endianness = DEVICE_LITTLE_ENDIAN,
> +};
> +

I think you need to define a write callback too (unless you're sure for
some other reason that the area will never be loaded).

Paolo