From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christian Borntraeger Subject: Re: [PATCH v2 0/2] KVM: s390: add floating irq controller Date: Mon, 07 Oct 2013 21:00:31 +0200 Message-ID: <525304CF.7040804@de.ibm.com> References: <1378469957-62290-1-git-send-email-jfrei@linux.vnet.ibm.com> <5229D8FE.90807@de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Gleb Natapov , Jens Freimann , Cornelia Huck , kvm@vger.kernel.org, qemu-devel@nongnu.org, Andreas Faerber , Thomas Huth , Peter Maydell , Christoffer Dall To: Alexander Graf Return-path: Received: from e06smtp16.uk.ibm.com ([195.75.94.112]:49964 "EHLO e06smtp16.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750954Ab3JGTAk (ORCPT ); Mon, 7 Oct 2013 15:00:40 -0400 Received: from /spool/local by e06smtp16.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 7 Oct 2013 20:00:38 +0100 Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 8D3A517D8057 for ; Mon, 7 Oct 2013 20:00:55 +0100 (BST) Received: from d06av04.portsmouth.uk.ibm.com (d06av04.portsmouth.uk.ibm.com [9.149.37.216]) by b06cxnps4074.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r97J0MMi65929334 for ; Mon, 7 Oct 2013 19:00:22 GMT Received: from d06av04.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av04.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id r97J0XFT022835 for ; Mon, 7 Oct 2013 13:00:34 -0600 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On 05/10/13 01:54, Alexander Graf wrote: > > On 06.09.2013, at 15:30, Christian Borntraeger wrote: > >> On 06/09/13 14:19, Jens Freimann wrote:> This series adds a kvm_device that acts as a irq controller for floating >>> interrupts. As a first step it implements functionality to retrieve and inject >>> interrupts for the purpose of migration and for hardening the reset code by >>> allowing user space to explicitly remove all pending floating interrupts. >>> >>> PFAULT patches will also use this device for enabling/disabling pfault, therefore >>> the pfault patch series will be reworked to use this device. >>> >>> * Patch 1/2 adds a new data structure to hold interrupt information. The current >>> one (struct kvm_s390_interrupt) does not allow to inject every kind of interrupt, >>> e.g. some data for program interrupts and machine check interruptions were >>> missing. >>> >>> * Patch 2/2 adds a kvm_device which supports getting/setting currently pending >>> floating interrupts as well as deleting all currently pending interrupts >>> >>> >>> Jens Freimann (2): >>> KVM: s390: add and extend interrupt information data structs >>> KVM: s390: add floating irq controller >>> >>> Documentation/virtual/kvm/devices/s390_flic.txt | 36 +++ >>> arch/s390/include/asm/kvm_host.h | 35 +-- >>> arch/s390/include/uapi/asm/kvm.h | 5 + >>> arch/s390/kvm/interrupt.c | 304 ++++++++++++++++++++---- >>> arch/s390/kvm/kvm-s390.c | 1 + >>> include/linux/kvm_host.h | 1 + >>> include/uapi/linux/kvm.h | 65 +++++ >>> virt/kvm/kvm_main.c | 5 + >>> 8 files changed, 368 insertions(+), 84 deletions(-) >>> create mode 100644 Documentation/virtual/kvm/devices/s390_flic.txt >>> >> >> >> Gleb, Paolo, >> >> since the qemu part relies on a kernel header file, it makes sense to not only let the kernel >> part go via the kvm tree, but also the qemu part. I want Alex to Ack the interface, and if he >> agrees then I am fine with applying the whole series. > > I think the interface works. My comments are almost exclusively on internal code structure which can follow up on a later patch. The only thing that definitely needs fixing now is the unnamed union. Will send a fixed version. Jens is working on patches to totally rework the internal structure for a while now. They will use a per-cpu bitfield for interrupt types as well as floating int bitfield. Each cpu will OR both bitfields and obey the architectures priority. These patches will take some more time and testing, so it makes sense to start with flic and let the other patches mature a bit. > > > Alex > >> >> If nothing else comes up, feel free to apply the small change request from Peter yourself or >> ask Jens for a resend. >> >> ------snip---- >> >> --- a/include/uapi/linux/kvm.h >> +++ b/include/uapi/linux/kvm.h >> @@ -908,7 +908,7 @@ struct kvm_device_attr { >> #define KVM_DEV_TYPE_FSL_MPIC_20 1 >> #define KVM_DEV_TYPE_FSL_MPIC_42 2 >> #define KVM_DEV_TYPE_XICS 3 >> -#define KVM_DEV_TYPE_FLIC 4 >> +#define KVM_DEV_TYPE_FLIC 5 >> >> /* >> * ioctls for VM fds >> >> ------snip---- >> >