From: Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com>
To: mingo@redhat.com, hpa@zytor.com, tglx@linutronix.de
Cc: Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com>,
x86@kernel.org, gleb@redhat.com, pbonzini@redhat.com,
konrad.wilk@oracle.com, habanero@linux.vnet.ibm.com,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
mtosatti@redhat.com, Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH] kvm fix: Enable pvspinlock after jump_label_init() to avoid VM hang
Date: Sun, 13 Oct 2013 13:38:57 +0530 [thread overview]
Message-ID: <525A5519.2050205@linux.vnet.ibm.com> (raw)
In-Reply-To: <1381309401-23663-1-git-send-email-raghavendra.kt@linux.vnet.ibm.com>
On 10/09/2013 02:33 PM, Raghavendra K T wrote:
> We use jump label to enable pv-spinlock. With the changes in
> (442e0973e927 Merge branch 'x86/jumplabel'), the jump label behaviour has changed
> that would result in evntual hang of the VM since we would end up in a situation
> where slowpath locks would halt the vcpus but we will not be able to wakeup the
> vcpu by lock releaser using unlock kick.
>
> Similar problem in Xen and more detailed description is available in
> a945928ea270 (xen: Do not enable spinlocks before jump_label_init() has executed)
>
> This patch splits kvm_spinlock_init to separate jump label changes with pvops
> patching and also make jump label enabling after jump_label_init().
>
> Signed-off-by: Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com>
Ingo,
Could you please take this fix?
This is reviewed by Paolo and Steven.
next prev parent reply other threads:[~2013-10-13 8:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-09 9:03 [PATCH] kvm fix: Enable pvspinlock after jump_label_init() to avoid VM hang Raghavendra K T
2013-10-09 9:23 ` Paolo Bonzini
2013-10-10 14:43 ` Steven Rostedt
2013-10-13 8:08 ` Raghavendra K T [this message]
2013-10-13 8:11 ` Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=525A5519.2050205@linux.vnet.ibm.com \
--to=raghavendra.kt@linux.vnet.ibm.com \
--cc=gleb@redhat.com \
--cc=habanero@linux.vnet.ibm.com \
--cc=hpa@zytor.com \
--cc=konrad.wilk@oracle.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).