From: Paolo Bonzini <pbonzini@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: "Gleb Natapov" <gleb@redhat.com>, kvm <kvm@vger.kernel.org>,
"\"李春奇 <Arthur Chunqi Li>\"" <yzt356@gmail.com>
Subject: Re: [PATCH][kvm-unit-tests] nEPT: Fix logic for testing read access
Date: Mon, 28 Oct 2013 14:10:27 +0100 [thread overview]
Message-ID: <526E6243.7010608@redhat.com> (raw)
In-Reply-To: <5267DB50.9060304@siemens.com>
Il 23/10/2013 16:21, Jan Kiszka ha scritto:
> We need to fail the test if MAGIC_VAL_1 cannot be found in either
> data_page1 or data_page2.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>
> BTW, this and the previous patch apply on top of the vmx queue of
> kvm-unit-tests.
>
> x86/vmx_tests.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/x86/vmx_tests.c b/x86/vmx_tests.c
> index a002a7a..8d47bcd 100644
> --- a/x86/vmx_tests.c
> +++ b/x86/vmx_tests.c
> @@ -956,7 +956,7 @@ static void ept_main()
> return;
> }
> set_stage(0);
> - if (*((u32 *)data_page2) != MAGIC_VAL_1 &&
> + if (*((u32 *)data_page2) != MAGIC_VAL_1 ||
> *((u32 *)data_page1) != MAGIC_VAL_1)
> report("EPT basic framework - read", 0);
> else {
>
Applied to kvm-unit-tests.git vmx.
Paolo
prev parent reply other threads:[~2013-10-28 13:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-23 14:21 [PATCH][kvm-unit-tests] nEPT: Fix logic for testing read access Jan Kiszka
2013-10-28 13:10 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=526E6243.7010608@redhat.com \
--to=pbonzini@redhat.com \
--cc=gleb@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=yzt356@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).