* [PATCH][kvm-unit-tests] nEPT: Fix logic for testing read access
@ 2013-10-23 14:21 Jan Kiszka
2013-10-28 13:10 ` Paolo Bonzini
0 siblings, 1 reply; 2+ messages in thread
From: Jan Kiszka @ 2013-10-23 14:21 UTC (permalink / raw)
To: Gleb Natapov, Paolo Bonzini
Cc: kvm, "李春奇 <Arthur Chunqi Li>"
We need to fail the test if MAGIC_VAL_1 cannot be found in either
data_page1 or data_page2.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
BTW, this and the previous patch apply on top of the vmx queue of
kvm-unit-tests.
x86/vmx_tests.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/x86/vmx_tests.c b/x86/vmx_tests.c
index a002a7a..8d47bcd 100644
--- a/x86/vmx_tests.c
+++ b/x86/vmx_tests.c
@@ -956,7 +956,7 @@ static void ept_main()
return;
}
set_stage(0);
- if (*((u32 *)data_page2) != MAGIC_VAL_1 &&
+ if (*((u32 *)data_page2) != MAGIC_VAL_1 ||
*((u32 *)data_page1) != MAGIC_VAL_1)
report("EPT basic framework - read", 0);
else {
--
1.8.1.1.298.ge7eed54
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH][kvm-unit-tests] nEPT: Fix logic for testing read access
2013-10-23 14:21 [PATCH][kvm-unit-tests] nEPT: Fix logic for testing read access Jan Kiszka
@ 2013-10-28 13:10 ` Paolo Bonzini
0 siblings, 0 replies; 2+ messages in thread
From: Paolo Bonzini @ 2013-10-28 13:10 UTC (permalink / raw)
To: Jan Kiszka
Cc: Gleb Natapov, kvm,
"李春奇 <Arthur Chunqi Li>"
Il 23/10/2013 16:21, Jan Kiszka ha scritto:
> We need to fail the test if MAGIC_VAL_1 cannot be found in either
> data_page1 or data_page2.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>
> BTW, this and the previous patch apply on top of the vmx queue of
> kvm-unit-tests.
>
> x86/vmx_tests.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/x86/vmx_tests.c b/x86/vmx_tests.c
> index a002a7a..8d47bcd 100644
> --- a/x86/vmx_tests.c
> +++ b/x86/vmx_tests.c
> @@ -956,7 +956,7 @@ static void ept_main()
> return;
> }
> set_stage(0);
> - if (*((u32 *)data_page2) != MAGIC_VAL_1 &&
> + if (*((u32 *)data_page2) != MAGIC_VAL_1 ||
> *((u32 *)data_page1) != MAGIC_VAL_1)
> report("EPT basic framework - read", 0);
> else {
>
Applied to kvm-unit-tests.git vmx.
Paolo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-10-28 13:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-23 14:21 [PATCH][kvm-unit-tests] nEPT: Fix logic for testing read access Jan Kiszka
2013-10-28 13:10 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).