From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH 1/4] kvm: Destroy & free KVM devices on release Date: Wed, 30 Oct 2013 16:42:15 +0100 Message-ID: <527128D7.9070603@redhat.com> References: <20131029160019.22578.16409.stgit@bling.home> <20131029161322.22578.18997.stgit@bling.home> <20131030104029.GE4651@redhat.com> <1383143422.4097.170.camel@ul30vt.home> <20131030153338.GI4651@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Alex Williamson , kvm@vger.kernel.org, aik@ozlabs.ru, linux-kernel@vger.kernel.org To: Gleb Natapov Return-path: In-Reply-To: <20131030153338.GI4651@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org Il 30/10/2013 16:33, Gleb Natapov ha scritto: > > Hmm, ok. In that case I can drop this patch and I think the rest just > > boils down to userspace use of the device. I had been close()'ing the > > kvm device fd when all QEMU vfio devices are detached, but I can just as > > easily leave it open in case a new device is added later. I'll send out > > a new series after doing some more review and testing. Do you have any > > comments on the rest of the series? Thanks, > > If I understand 4/4 correctly if there is VFIO device connected we > assume non coherent domain. How hard it would be to do proper checking > in this path series? Yes, that's my understanding as well. Is the performance impact measurable? Paolo