From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH 2/3] KVM: emulator: cleanup decode_register_operand() a bit Date: Mon, 04 Nov 2013 15:05:35 +0100 Message-ID: <5277A9AF.4090009@redhat.com> References: <1383573163-17865-1-git-send-email-gleb@redhat.com> <1383573163-17865-2-git-send-email-gleb@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Gleb Natapov Return-path: Received: from mx1.redhat.com ([209.132.183.28]:16212 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752188Ab3KDOFh (ORCPT ); Mon, 4 Nov 2013 09:05:37 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rA4E5boF003392 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 4 Nov 2013 09:05:37 -0500 In-Reply-To: <1383573163-17865-2-git-send-email-gleb@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Il 04/11/2013 14:52, Gleb Natapov ha scritto: > Make code shorter. > > Signed-off-by: Gleb Natapov > --- > arch/x86/kvm/emulate.c | 10 +++------- > 1 file changed, 3 insertions(+), 7 deletions(-) > > diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c > index 0bd372f..07ffca0 100644 > --- a/arch/x86/kvm/emulate.c > +++ b/arch/x86/kvm/emulate.c > @@ -1045,13 +1045,9 @@ static void decode_register_operand(struct x86_emulate_ctxt *ctxt, > } > > op->type = OP_REG; > - if (ctxt->d & ByteOp) { > - op->addr.reg = decode_register(ctxt, reg, true); > - op->bytes = 1; > - } else { > - op->addr.reg = decode_register(ctxt, reg, false); > - op->bytes = ctxt->op_bytes; > - } > + op->bytes = (ctxt->d & ByteOp) ? 1 : ctxt->op_bytes; > + op->addr.reg = decode_register(ctxt, reg, ctxt->d & ByteOp); > + > fetch_register_operand(op); > op->orig_val = op->val; > } > Not sure I prefer the new code, but beauty is in the eye of the beholder. :) Reviewed-by: Paolo Bonzini