Re: [PATCH 3/3] KVM: x86: trace cpuid emulation when called from emulator

[Paolo Bonzini <pbonzini@redhat.com>]

Il 04/11/2013 14:52, Gleb Natapov ha scritto:
> Currently cpuid emulation is traced only when executed by intercept.
> Move trace point so that emulator invocation is traced too.
> 
> Signed-off-by: Gleb Natapov <gleb@redhat.com>
> ---
>  arch/x86/kvm/cpuid.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kvm/cpuid.c b/arch/x86/kvm/cpuid.c
> index 86d5756..8f66fba 100644
> --- a/arch/x86/kvm/cpuid.c
> +++ b/arch/x86/kvm/cpuid.c
> @@ -756,6 +756,7 @@ void kvm_cpuid(struct kvm_vcpu *vcpu, u32 *eax, u32 *ebx, u32 *ecx, u32 *edx)
>  		*edx = best->edx;
>  	} else
>  		*eax = *ebx = *ecx = *edx = 0;
> +	trace_kvm_cpuid(function, *eax, *ebx, *ecx, *edx);
>  }
>  EXPORT_SYMBOL_GPL(kvm_cpuid);
>  
> @@ -771,6 +772,5 @@ void kvm_emulate_cpuid(struct kvm_vcpu *vcpu)
>  	kvm_register_write(vcpu, VCPU_REGS_RCX, ecx);
>  	kvm_register_write(vcpu, VCPU_REGS_RDX, edx);
>  	kvm_x86_ops->skip_emulated_instruction(vcpu);
> -	trace_kvm_cpuid(function, eax, ebx, ecx, edx);
>  }
>  EXPORT_SYMBOL_GPL(kvm_emulate_cpuid);
> 

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>