From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH uq/master] KVM: x86: fix typo in KVM_GET_XCRS Date: Mon, 04 Nov 2013 16:56:04 +0100 Message-ID: <5277C394.7060409@redhat.com> References: <1382021272-6059-1-git-send-email-pbonzini@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: qemu-devel@nongnu.org, gleb@redhat.com, kvm@vger.kernel.org To: unlisted-recipients:; (no To-header on input) Return-path: Received: from mail-qa0-f48.google.com ([209.85.216.48]:56372 "EHLO mail-qa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750887Ab3KDP4K (ORCPT ); Mon, 4 Nov 2013 10:56:10 -0500 Received: by mail-qa0-f48.google.com with SMTP id w8so319397qac.0 for ; Mon, 04 Nov 2013 07:56:08 -0800 (PST) In-Reply-To: <1382021272-6059-1-git-send-email-pbonzini@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Il 17/10/2013 16:47, Paolo Bonzini ha scritto: > Only the first item of the array was ever looked at. No > practical effect, but still worth fixing. > > Signed-off-by: Paolo Bonzini > --- > target-i386/kvm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/target-i386/kvm.c b/target-i386/kvm.c > index 749aa09..27071e3 100644 > --- a/target-i386/kvm.c > +++ b/target-i386/kvm.c > @@ -1314,8 +1314,8 @@ static int kvm_get_xcrs(X86CPU *cpu) > > for (i = 0; i < xcrs.nr_xcrs; i++) { > /* Only support xcr0 now */ > - if (xcrs.xcrs[0].xcr == 0) { > - env->xcr0 = xcrs.xcrs[0].value; > + if (xcrs.xcrs[i].xcr == 0) { > + env->xcr0 = xcrs.xcrs[i].value; > break; > } > } > Ping?