From: Paolo Bonzini <pbonzini@redhat.com>
To: Gleb Natapov <gleb@redhat.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: remove vm mmap method
Date: Tue, 05 Nov 2013 17:15:42 +0100 [thread overview]
Message-ID: <527919AE.7050307@redhat.com> (raw)
In-Reply-To: <20131105161211.GF31020@redhat.com>
Il 05/11/2013 17:12, Gleb Natapov ha scritto:
> > I think it is usable (perhaps not useful...) on its own, though. It is
> > just 40 lines of self-contained code, keeping it doesn't do any harm.
>
> Usable for what?
Usable, not useful. Perhaps someone prefers to map the guest address
space instead of using the memory areas they registrated.
> So this is just 40 lines of dead code, but it is not only dead it is
> outdated. The code around it evolved and nobody adjusted it. The
> code will fail to access memory in read only slot for instance (there
> was no read only slots back then).
You're right it's broken for RO slots. Go ahead and zap it. :)
Paolo
prev parent reply other threads:[~2013-11-05 16:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-05 14:04 [PATCH] KVM: remove vm mmap method Gleb Natapov
2013-11-05 14:16 ` Paolo Bonzini
2013-11-05 16:12 ` Gleb Natapov
2013-11-05 16:15 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=527919AE.7050307@redhat.com \
--to=pbonzini@redhat.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox