From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH] KVM: remove vm mmap method Date: Tue, 05 Nov 2013 17:15:42 +0100 Message-ID: <527919AE.7050307@redhat.com> References: <20131105140417.GP7513@redhat.com> <5278FDC7.6070908@redhat.com> <20131105161211.GF31020@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Gleb Natapov Return-path: Received: from mx1.redhat.com ([209.132.183.28]:31715 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755073Ab3KEQPq (ORCPT ); Tue, 5 Nov 2013 11:15:46 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rA5GFj4C022063 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 5 Nov 2013 11:15:46 -0500 In-Reply-To: <20131105161211.GF31020@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Il 05/11/2013 17:12, Gleb Natapov ha scritto: > > I think it is usable (perhaps not useful...) on its own, though. It is > > just 40 lines of self-contained code, keeping it doesn't do any harm. > > Usable for what? Usable, not useful. Perhaps someone prefers to map the guest address space instead of using the memory areas they registrated. > So this is just 40 lines of dead code, but it is not only dead it is > outdated. The code around it evolved and nobody adjusted it. The > code will fail to access memory in read only slot for instance (there > was no read only slots back then). You're right it's broken for RO slots. Go ahead and zap it. :) Paolo