Re: [PATCH for-1.7] target-i386: Fix build by providing stub kvm_arch_get_supported_cpuid()

Paolo Bonzini
2013-11-12T14:57:41Z

Il 12/11/2013 15:09, Gleb Natapov ha scritto:
> On Tue, Nov 12, 2013 at 02:57:49PM +0100, Paolo Bonzini wrote:
>> Il 12/11/2013 14:23, Gleb Natapov ha scritto:
>>>> If -O0 does not do that, let's move debug builds to -O1.
>>>
>>> Why not enable dce with -fdce?
>>
>> First, because clang doesn't have fine-tuned optimization options (at
>> least I couldn't find them and -fdce doesn't work).
>
> -O1 then for clang.

We can even test in configure for the exact optimizations we want, in
fact. But I think -O1 doesn't sacrifice debuggability that much:

http://www.redhat.com/magazine/011sep05/features/gcc/

-O0 Barely any transformations are done to the code, just code
generation. At this level, the target code can be debugged with
no loss of information.

-O1 Some transformations that preserve execution ordering.
Debuggability of the generated code is hardly affected. User
variables should not disappear and function inlining is not
done.

-O2 More aggressive transformations that may affect execution
ordering and usually provide faster code. Debuggability may be
somewhat compromised by disappearing user variables and
function bodies.

Not very recent, but things have remained roughly the same and gdb also
has improved.

Hmm... I just found out that GCC has a shiny new "-Og" option to
optimize for debuggability and still producing good code. Using "-Og"
if it is present, and -O1 otherwise, seems like a good idea to me for
1.8. For 1.7 it can just be -O1.

>> Second, because most optimization options are no-ops at -O0 (try "-fdce
>> -fdump-tree-all" with GCC.
>>
> Strange. Is this by design? We can do -O1 and bunch of "-fno-" to
> disable most of optimizations -O1 enables, but this is ugly.

Yes, some data structures (I'm not up to date as to which exactly) are
not even built at -O0 to make compilation faster, and they're required
for most optimizations.

Paolo