Re: [Qemu-devel] [PATCH for-1.7] target-i386: Fix build by providing stub kvm_arch_get_supported_cpuid()

Peter Maydell
2013-11-13T22:23:58Z

On 13 November 2013 07:25, Paolo Bonzini <pbonzini@redhat.com> wrote:
> Il 13/11/2013 03:27, Richard Henderson ha scritto:
>> I think it's also worthwhile to implement the kvm api in kvm-stub.c,
>> unnecessary or not. If you really want compile-time feedback on those that
>> ought to have been removed by optimization, you could elide them from the stub
>> file depending on ifndef __OPTIMIZE__.
>
> Good idea. Peter, can you do that?

I still think this serves no useful purpose and we'd be better off
without such an ifndef, but I'd rather have a guarded stub than
no stub, so I'll send a patch in a moment.

thanks
-- PMM