From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Weil <sw@weilnetz.de>
Subject: Re: [PATCH for-1.7] target-i386: Fix build by
 providing stub kvm_arch_get_supported_cpuid()
Date: Tue, 12 Nov 2013 20:15:54 +0100
Message-ID: <52827E6A.7050603@weilnetz.de>
References: <5281580D.7060305@redhat.com>	<CAFEAcA9oxAGZ3h-qkO32WJ-3TSZwMquYBfVhJ=oUqgBX8rqiow@mail.gmail.com>	<52816422.8060002@redhat.com>	<CA+aC4ksHwQnyYoofHd8U_uRarcB7Ynr_ekCVmYovaj7KnhHhfQ@mail.gmail.com>	<CAFEAcA8UjSRze-Zz1jdE2sS0GM5ihfoN5Dz6Gj8MPF_iXUOewA@mail.gmail.com>	<52821A62.2050001@redhat.com>	<CAFEAcA8huEkY5pkiwCseXBBugOidXQBMS0HBoRWqsOhHxU7r2g@mail.gmail.com>	<52822958.8060508@redhat.com>
	<20131112132337.GB2008@redhat.com>	<528233DD.6020306@redhat.com>
	<20131112140935.GD2008@redhat.com>	<528241E0.5060503@redhat.com>	<CAFEAcA_itCrpH7sqe3HBhNK_7GoaAWO77zbttLbjucHt3YJF3Q@mail.gmail.com>	<52824766.2000507@redhat.com>	<CAFEAcA9KEQ7XjVk=Ez+Yb0_vrzk6GcFRj7PiT8faSg6U4dwJHA@mail.gmail.com>	<52825009.10506@redhat.com>	<CAFEAcA_ezBN-vA_2i0HQ-oxnU1bL_Owvht7wX6qKyEOpM5VOUQ@mail.gmail.com>	<CA+aC4kuuwuPB6YgZtHT+8kJ+JZSe3AokfvEGxk9ocTb5NFzg4Q@mail.gmail.com>	<5282794D.20108@twiddle.net>
	<CAFEAcA_eikGjppSv_UBF+BKHMq4JbA-T_hYgm=v_sKpRuR2AjA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: kvm-devel <kvm@vger.kernel.org>, Gleb Natapov <gleb@redhat.com>,
	Patch Tracking <patches@linaro.org>,
	QEMU Developers <qemu-devel@nongnu.org>,
	Andreas Tobler <andreast@freebsd.org>,
	Anthony Liguori <anthony@codemonkey.ws>,
	Paolo Bonzini <pbonzini@redhat.com>, Anthony Liguori <aliguori@amazon.com>
To: Peter Maydell <peter.maydell@linaro.org>,
	Richard Henderson <rth@twiddle.net>
Return-path: <qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org>
In-Reply-To: <CAFEAcA_eikGjppSv_UBF+BKHMq4JbA-T_hYgm=v_sKpRuR2AjA@mail.gmail.com>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org
Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org
List-Id: kvm.vger.kernel.org

Am 12.11.2013 19:57, schrieb Peter Maydell:
> On 12 November 2013 18:54, Richard Henderson <rth@twiddle.net> wrote:
>> For what it's worth, I think BOTH of the patches that have been posted
>> should be applied.  That is, the patch that does (X || 1) -> (1 || X),
>> and the patch that adds the stub.
> I think that makes sense and would be happy with that as a resolution.
>
> thanks
> -- PMM
>

+1.

By the way: I added a stub for kvm_arch_get_supported_cpuid() in my kvm
patch, too
(see http://patchwork.ozlabs.org/patch/260512/). It called
g_assert_not_reached()instead
of returning 0.Maybe this can be added in a later patch.

Regards,
Stefan