From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Stefan Weil <sw@weilnetz.de>,
QEMU Developers <qemu-devel@nongnu.org>,
Gleb Natapov <gleb@redhat.com>, kvm-devel <kvm@vger.kernel.org>,
Patch Tracking <patches@linaro.org>,
Andreas Tobler <andreast@freebsd.org>,
Anthony Liguori <aliguori@amazon.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH v2 for-1.7] target-i386: Fix build by providing stub kvm_arch_get_supported_cpuid()
Date: Thu, 14 Nov 2013 12:17:30 +0100 [thread overview]
Message-ID: <5284B14A.9070305@redhat.com> (raw)
In-Reply-To: <CAFEAcA_CJL+7mkyhzYnfD_=x_60XQ902sAgOHxRn9ebhmg-EcQ@mail.gmail.com>
Il 14/11/2013 12:06, Peter Maydell ha scritto:
> On 14 November 2013 05:40, Stefan Weil <sw@weilnetz.de> wrote:
>> If you happen to write a v3 patch, g_assert_not_reached would be even
>> better than abort.
>>
>> It's impossible to tell why QEMU terminated after an assert without a
>> debugger,
>> whereas g_assert_not_reached clearly shows the location.
>
> Maybe. I was mostly just following the pattern of existing
> stub functions. Should all instances of abort() be replaced?
> (g_assert_not_reached() is compile-time disablable, unlike
> abort()).
No, disabling asserts is almost always bad, but disabling unconditional
asserts is even worse.
Paolo
next prev parent reply other threads:[~2013-11-14 11:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-13 23:09 [PATCH v2 for-1.7] target-i386: Fix build by providing stub kvm_arch_get_supported_cpuid() Peter Maydell
2013-11-14 5:40 ` Stefan Weil
2013-11-14 11:06 ` [Qemu-devel] " Peter Maydell
2013-11-14 11:17 ` Paolo Bonzini [this message]
2013-11-14 8:53 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5284B14A.9070305@redhat.com \
--to=pbonzini@redhat.com \
--cc=aliguori@amazon.com \
--cc=andreast@freebsd.org \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox