From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 for-1.7] target-i386: Fix build by providing
 stub kvm_arch_get_supported_cpuid()
Date: Thu, 14 Nov 2013 12:17:30 +0100
Message-ID: <5284B14A.9070305@redhat.com>
References: <1384384147-11076-1-git-send-email-peter.maydell@linaro.org> <52846263.1020608@weilnetz.de> <CAFEAcA_CJL+7mkyhzYnfD_=x_60XQ902sAgOHxRn9ebhmg-EcQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: Stefan Weil <sw@weilnetz.de>,
	QEMU Developers <qemu-devel@nongnu.org>,
	Gleb Natapov <gleb@redhat.com>,
	kvm-devel <kvm@vger.kernel.org>,
	Patch Tracking <patches@linaro.org>,
	Andreas Tobler <andreast@freebsd.org>,
	Anthony Liguori <aliguori@amazon.com>,
	Richard Henderson <rth@twiddle.net>
To: Peter Maydell <peter.maydell@linaro.org>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:58830 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753307Ab3KNLRr (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 14 Nov 2013 06:17:47 -0500
In-Reply-To: <CAFEAcA_CJL+7mkyhzYnfD_=x_60XQ902sAgOHxRn9ebhmg-EcQ@mail.gmail.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Il 14/11/2013 12:06, Peter Maydell ha scritto:
> On 14 November 2013 05:40, Stefan Weil <sw@weilnetz.de> wrote:
>> If you happen to write a v3 patch, g_assert_not_reached would be even
>> better than abort.
>>
>> It's impossible to tell why QEMU terminated after an assert without a
>> debugger,
>> whereas g_assert_not_reached clearly shows the location.
> 
> Maybe. I was mostly just following the pattern of existing
> stub functions. Should all instances of abort() be replaced?
> (g_assert_not_reached() is compile-time disablable, unlike
> abort()).

No, disabling asserts is almost always bad, but disabling unconditional
asserts is even worse.

Paolo