From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [RFC] target-arm: Provide mechanism for getting KVM constants even if not CONFIG_KVM Date: Fri, 15 Nov 2013 12:33:08 +0100 Message-ID: <52860674.4040904@redhat.com> References: <1384456020-12251-1-git-send-email-peter.maydell@linaro.org> <5285FD71.60707@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: QEMU Developers , Patch Tracking , kvm-devel , Gleb Natapov To: Peter Maydell Return-path: Received: from mx1.redhat.com ([209.132.183.28]:20251 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753915Ab3KOLdP (ORCPT ); Fri, 15 Nov 2013 06:33:15 -0500 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: Il 15/11/2013 12:26, Peter Maydell ha scritto: >> > It's okay. There are indeed advantages to putting this together with >> > the definitions, instead of splitting it between target-arm/cpu.h and >> > target-arm/kvm.c. > Cool. I just wanted to check I wasn't missing some > clever approach to this that might have avoided the > need to duplicate all the definitions. If you call your constants KVM_FOO, the compiler should not warn for a redefinition with the exact same content. But I find that more gross than clever... Paolo