From: Santosh Shilimkar <santosh.shilimkar@ti.com>
To: Christoffer Dall <christoffer.dall@linaro.org>
Cc: Marc Zyngier <marc.zyngier@arm.com>,
<kvmarm@lists.cs.columbia.edu>, <kvm@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <patches@linaro.org>
Subject: Re: [PATCH] arm/arm64: KVM: Fix hyp mappings of vmalloc regions
Date: Sat, 16 Nov 2013 18:30:31 -0500 [thread overview]
Message-ID: <52880017.8060006@ti.com> (raw)
In-Reply-To: <20131116171524.GK20516@lvm>
On Saturday 16 November 2013 12:15 PM, Christoffer Dall wrote:
> On Sat, Nov 16, 2013 at 10:01:01AM +0000, Marc Zyngier wrote:
>> On 2013-11-15 23:24, Christoffer Dall wrote:
>>> Using virt_to_phys on percpu mappings is horribly wrong as it may be
>>> backed by vmalloc. Introduce kvm_kaddr_to_phys which translates both
>>> types of valid kernel addresses to the corresponding physical
>>> address.
>>>
>>> At the same time resolves a typing issue where we were storing the
>>> physical address as a 32 bit unsigned long (on arm), truncating the
>>> physical address for addresses above the 4GB limit. This caused
>>> breakage on Keystone.
>>>
>>> Reported-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
>>> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
>>> Signed-off-by: Christoffer Dall <christoffer.dall@linaro.org>
>>> ---
>>>
>>> This patch is loosely based on Marc's previous patch from today but
>>> instead of introducing another Hyp mapping function, it fixes the
>>> existing one to deal with both kinds of kernel addresses.
>>
>> Looks good to me! This should probably be merged quickly (after
>> testing by Santosh), and possibly Cc-ed to stable.
>>
> Agreed, Santhos, can you give this a quick spin?
>
Works as expected.
Regards,
Santosh
next prev parent reply other threads:[~2013-11-16 23:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-15 23:24 [PATCH] arm/arm64: KVM: Fix hyp mappings of vmalloc regions Christoffer Dall
2013-11-16 10:01 ` Marc Zyngier
2013-11-16 17:15 ` Christoffer Dall
2013-11-16 23:30 ` Santosh Shilimkar [this message]
2013-11-17 1:26 ` Christoffer Dall
-- strict thread matches above, loose matches on Subject: below --
2013-11-18 21:13 [GIT PULL] Fix vmalloc allocations for KVM/ARM Christoffer Dall
2013-11-18 21:13 ` [PATCH] arm/arm64: KVM: Fix hyp mappings of vmalloc regions Christoffer Dall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52880017.8060006@ti.com \
--to=santosh.shilimkar@ti.com \
--cc=christoffer.dall@linaro.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=marc.zyngier@arm.com \
--cc=patches@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox