From mboxrd@z Thu Jan 1 00:00:00 1970 From: Santosh Shilimkar Subject: Re: [PATCH] arm/arm64: KVM: Fix hyp mappings of vmalloc regions Date: Sat, 16 Nov 2013 18:30:31 -0500 Message-ID: <52880017.8060006@ti.com> References: <1384557880-14107-1-git-send-email-christoffer.dall@linaro.org> <87846f3195cadcae32824120f78e3c9d@www.loen.fr> <20131116171524.GK20516@lvm> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Cc: Marc Zyngier , , , , To: Christoffer Dall Return-path: Received: from arroyo.ext.ti.com ([192.94.94.40]:53401 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752743Ab3KPXbJ (ORCPT ); Sat, 16 Nov 2013 18:31:09 -0500 In-Reply-To: <20131116171524.GK20516@lvm> Sender: kvm-owner@vger.kernel.org List-ID: On Saturday 16 November 2013 12:15 PM, Christoffer Dall wrote: > On Sat, Nov 16, 2013 at 10:01:01AM +0000, Marc Zyngier wrote: >> On 2013-11-15 23:24, Christoffer Dall wrote: >>> Using virt_to_phys on percpu mappings is horribly wrong as it may be >>> backed by vmalloc. Introduce kvm_kaddr_to_phys which translates both >>> types of valid kernel addresses to the corresponding physical >>> address. >>> >>> At the same time resolves a typing issue where we were storing the >>> physical address as a 32 bit unsigned long (on arm), truncating the >>> physical address for addresses above the 4GB limit. This caused >>> breakage on Keystone. >>> >>> Reported-by: Santosh Shilimkar >>> Signed-off-by: Marc Zyngier >>> Signed-off-by: Christoffer Dall >>> --- >>> >>> This patch is loosely based on Marc's previous patch from today but >>> instead of introducing another Hyp mapping function, it fixes the >>> existing one to deal with both kinds of kernel addresses. >> >> Looks good to me! This should probably be merged quickly (after >> testing by Santosh), and possibly Cc-ed to stable. >> > Agreed, Santhos, can you give this a quick spin? > Works as expected. Regards, Santosh