From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Weil Subject: Re: [PATCH for 1.7] kvm: Fix uninitialized cpuid_data Date: Wed, 20 Nov 2013 19:54:33 +0100 Message-ID: <528D0569.3080308@weilnetz.de> References: <1383773727-29327-1-git-send-email-sw@weilnetz.de> <20131107111516.GB7513@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: qemu-devel , Marcelo Tosatti , Paolo Bonzini , kvm@vger.kernel.org, Anthony Liguori To: Gleb Natapov Return-path: Received: from v220110690675601.yourvserver.net ([37.221.199.173]:55275 "EHLO v220110690675601.yourvserver.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754550Ab3KTSys (ORCPT ); Wed, 20 Nov 2013 13:54:48 -0500 In-Reply-To: <20131107111516.GB7513@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Am 07.11.2013 12:15, schrieb Gleb Natapov: > On Wed, Nov 06, 2013 at 10:35:27PM +0100, Stefan Weil wrote: >> This error was reported by valgrind when running qemu-system-x86_64 >> with kvm: >> >> ==975== Conditional jump or move depends on uninitialised value(s) >> ==975== at 0x521C38: cpuid_find_entry (kvm.c:176) >> ==975== by 0x5235BA: kvm_arch_init_vcpu (kvm.c:686) >> ==975== by 0x4D5175: kvm_init_vcpu (kvm-all.c:267) >> ==975== by 0x45035B: qemu_kvm_cpu_thread_fn (cpus.c:858) >> ==975== by 0xD361E0D: start_thread (pthread_create.c:311) >> ==975== by 0xD65E9EC: clone (clone.S:113) >> ==975== Uninitialised value was created by a stack allocation >> ==975== at 0x5226E4: kvm_arch_init_vcpu (kvm.c:446) >> >> Instead of adding more memset calls for parts of cpuid_data, the existing >> calls were removed and cpuid_data is now initialized completely in one >> call. >> >> Signed-off-by: Stefan Weil > Applied, thanks. Ping. This bug fix for KVM is still missing in QEMU 1.7. Regards, Stefan